Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Renaissance for All Platforms #1494

Merged
merged 1 commit into from
Dec 7, 2019
Merged

Enable Renaissance for All Platforms #1494

merged 1 commit into from
Dec 7, 2019

Conversation

piyush286
Copy link
Contributor

  • Expanded coverage from xLinux to all platforms

Issue: #1457

Signed-off-by: Piyush Gupta piyush286@gmail.com

@piyush286
Enable Renaissance for All Platforms
517e148 
- Expanded coverage from xLinux to all platforms

Issue: adoptium#1457

Signed-off-by: Piyush Gupta <piyush286@gmail.com>
@piyush286
Copy link
Contributor Author

piyush286 commented Dec 6, 2019 •
edited by smlambert
Loading

Requesting review from @smlambert.

I've run all the Renaissance tests against all platforms. There were some failures on some platforms, and they seem to be benchmark issues. Those failures are seen with both HotSpot and OpenJ9. I've created issues for them:

renaissance-benchmarks/renaissance#210
renaissance-benchmarks/renaissance#211

I've disabled the failing tests on relevant platforms, and I launched runs again just for the failing target to show that those targets got skipped as intended.

All enabled tests on all platforms pass. You can find the links below:

openjdk_x86-64_linux

https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1225/console
All passed

https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1264/console
16:36:19 TOTAL: 1 EXECUTED: 1 PASSED: 1 FAILED: 0 DISABLED: 0 SKIPPED: 0
16:36:19 ALL TESTS PASSED
16:36:19 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
16:36:19
16:36:19 _db-shootout done

openjdk_x86-64_linux_xl

https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1247/console
All passed

openjdk_aarch32_linux

https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1236/console
13:51:35 gzip: openjdk8?openjdk_impl=openj9&os=linux&arch=aarch32&release=latest&type=jdk&heap_size=normal: not in gzip format
Unrelated to this PR

openjdk_aarch64_linux

https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1234/console
13:50:05 gzip: openjdk8?openjdk_impl=openj9&os=linux&arch=aarch64&release=latest&type=jdk&heap_size=normal: not in gzip format
Unrelated to this PR

openjdk_ppc64_aix

https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1248/console
01:20:45 FAILED test targets:
01:20:45 db-shootout_0
01:20:45 naive-bayes_0
01:20:45
01:20:45 TOTAL: 17 EXECUTED: 17 PASSED: 15 FAILED: 2 DISABLED: 0 SKIPPED: 0

db-shootout
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1259/console
16:37:50 TOTAL: 1 EXECUTED: 0 PASSED: 0 FAILED: 0 DISABLED: 0 SKIPPED: 1
16:37:50 ALL TESTS PASSED
16:37:50 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
16:37:50
16:37:50 _db-shootout done

naive-bayes
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1257/console
16:25:07 TOTAL: 1 EXECUTED: 1 PASSED: 1 FAILED: 0 DISABLED: 0 SKIPPED: 0
16:25:07 ALL TESTS PASSED
16:25:07 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
16:25:07
16:25:07 _naive-bayes done

openjdk_ppc64le_linux

https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1249/console
19:17:15 FAILED test targets:
19:17:15 db-shootout_0
19:17:15
19:17:15 TOTAL: 17 EXECUTED: 17 PASSED: 16 FAILED: 1 DISABLED: 0 SKIPPED: 0

db-shootout
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1258/console
15:20:44 TOTAL: 1 EXECUTED: 0 PASSED: 0 FAILED: 0 DISABLED: 0 SKIPPED: 1
15:20:44 ALL TESTS PASSED
15:20:44 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
15:20:44
15:20:44 _db-shootout done

openjdk_s390x_linux

https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1232/console
All passed

openjdk_s390x_zos

No machine

openjdk_x86-64_mac

https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1231/console
All passed

openjdk_x86-64_mac_xl

https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1250/console
All passed

openjdk_x86-64_windows

https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1253/console
15:20:12 FAILED test targets:
15:20:12 finagle-chirper_0
15:20:12
15:20:12 TOTAL: 17 EXECUTED: 17 PASSED: 16 FAILED: 1 DISABLED: 0 SKIPPED: 0

finagle-chirper, test-packet-x64-windows-2012r2-1
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1260/console
15:26:23 ./openjdk-tests/get.sh: line 16: $'\r': command not found => https://adoptopenjdk.slack.com/archives/C5219G28G/p1575542609074700 (see adoptium/infrastructure#1023)

finagle-chirper, test-godaddy-win2016-x64-4
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1262/console
15:42:24 TOTAL: 1 EXECUTED: 0 PASSED: 0 FAILED: 0 DISABLED: 0 SKIPPED: 1
15:42:24 ALL TESTS PASSED
15:42:24 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
15:42:24
15:42:25 _finagle-chirper done
1

openjdk_x86-32_windows

https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1255/console
15:11:55 FAILED test targets:
15:11:55 finagle-chirper_0
15:11:55
15:11:55 TOTAL: 17 EXECUTED: 17 PASSED: 16 FAILED: 1 DISABLED: 0 SKIPPED: 0

finagle-chirper
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1261/console
15:28:09 TOTAL: 1 EXECUTED: 0 PASSED: 0 FAILED: 0 DISABLED: 0 SKIPPED: 1
15:28:09 ALL TESTS PASSED
15:28:09 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
15:28:09
15:28:09 _finagle-chirper done

@piyush286 piyush286 mentioned this pull request Dec 7, 2019
Closed
4 tasks
@smlambert
Copy link
Contributor

There is no openj9 aarch32 build, so ran against hotspot here:
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1268/console (needed to turn off auto-detect due to an issue found: adoptium/TKG#18)

smlambert
smlambert approved these changes Dec 7, 2019
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @piyush286 !

@smlambert smlambert merged commit 8e80900 into adoptium:master Dec 7, 2019
@piyush286 piyush286 deleted the renaissance branch December 7, 2019 18:39
@karianna karianna added this to the December 2019 milestone Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
December 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@piyush286 @smlambert @karianna