Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getDependencies.pl customUrl should not hardcode to https://ci.adoptium.net #5286

Open
llxia opened this issue May 7, 2024 · 2 comments
Open

Comments

@llxia
Copy link
Contributor

llxia commented May 7, 2024

getDependencies.pl customUrl should not hardcode to https://ci.adoptium.net Jenkins. We should change it based on the Jenkins domain:

def customUrl = "https://ci.adoptium.net/job/test.getDependency/lastSuccessfulBuild/artifact/"

We can leverage the following for Jenkins domain value:

def getJenkinsDomain() {

This allows each vendor to adjust test.getDependency job if needed.

related: #5283 (comment)

@llxia
Copy link
Contributor Author

llxia commented May 7, 2024

@annaibm please take a look. Thanks

annaibm added a commit to annaibm/aqa-tests that referenced this issue May 7, 2024
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain()

resolves:adoptium#5286

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
@llxia
Copy link
Contributor Author

llxia commented May 7, 2024

@annaibm I just remembered that we would not be able to access the Jenkins URL if anonymous access is not allowed. This was one of the reasons that we set Adoptium jenkins URL in the first place. Please add the check:

if JenkinsDomain contains `hyc-runtimes`
   use openj9 Jenkins
else
    use JenkinsDomain

annaibm added a commit to annaibm/aqa-tests that referenced this issue May 7, 2024
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain()

resolves:adoptium#5286

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
annaibm added a commit to annaibm/aqa-tests that referenced this issue May 7, 2024
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain()

resolves:adoptium#5286

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
annaibm added a commit to annaibm/aqa-tests that referenced this issue May 7, 2024
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain()

resolves:adoptium#5286

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
annaibm added a commit to annaibm/aqa-tests that referenced this issue May 7, 2024
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain()

resolves:adoptium#5286

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
annaibm added a commit to annaibm/aqa-tests that referenced this issue May 15, 2024
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain()

resolves:adoptium#5286

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
karianna pushed a commit that referenced this issue May 16, 2024
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain()

resolves:#5286

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant