-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getDependencies.pl customUrl should not hardcode to https://ci.adoptium.net #5286
Labels
Comments
@annaibm please take a look. Thanks |
annaibm
added a commit
to annaibm/aqa-tests
that referenced
this issue
May 7, 2024
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain() resolves:adoptium#5286 Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
@annaibm I just remembered that we would not be able to access the Jenkins URL if anonymous access is not allowed. This was one of the reasons that we set Adoptium jenkins URL in the first place. Please add the check:
|
annaibm
added a commit
to annaibm/aqa-tests
that referenced
this issue
May 7, 2024
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain() resolves:adoptium#5286 Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
annaibm
added a commit
to annaibm/aqa-tests
that referenced
this issue
May 7, 2024
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain() resolves:adoptium#5286 Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
annaibm
added a commit
to annaibm/aqa-tests
that referenced
this issue
May 7, 2024
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain() resolves:adoptium#5286 Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
annaibm
added a commit
to annaibm/aqa-tests
that referenced
this issue
May 7, 2024
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain() resolves:adoptium#5286 Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
annaibm
added a commit
to annaibm/aqa-tests
that referenced
this issue
May 15, 2024
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain() resolves:adoptium#5286 Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
karianna
pushed a commit
that referenced
this issue
May 16, 2024
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain() resolves:#5286 Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
getDependencies.pl
customUrl
should not hardcode to https://ci.adoptium.net Jenkins. We should change it based on the Jenkins domain:aqa-tests/buildenv/jenkins/JenkinsfileBase
Line 210 in 9639787
We can leverage the following for Jenkins domain value:
aqa-tests/buildenv/jenkins/JenkinsfileBase
Line 1046 in 9639787
This allows each vendor to adjust
test.getDependency
job if needed.related: #5283 (comment)
The text was updated successfully, but these errors were encountered: