Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude win32 compiler tests with JDK17 #3004

Closed
sophia-guo opened this issue Oct 15, 2021 · 8 comments · Fixed by #3006
Closed

Exclude win32 compiler tests with JDK17 #3004

sophia-guo opened this issue Oct 15, 2021 · 8 comments · Fixed by #3006
Assignees

Comments

@sophia-guo
Copy link
Contributor

Compiler tests on win32 failed with errortUnrecognized VM options, looks like those options are only recognized by a GC implementation which is not built on win32.
#2382

https://ci.adoptopenjdk.net/job/Test_openjdk17_hs_extended.openjdk_x86-32_windows_testList_0/10/

Those test should be excluded on win32.

The following section should be added in https://github.com/adoptium/aqa-tests/blob/master/openjdk/excludes/ProblemList_openjdk17.txt

############################################################################

# jvm_compiler

compiler/arraycopy/TestCloneAccess.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/arraycopy/TestCloneAccessStressGCM.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/cr6340864/TestByteVect.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/cr6340864/TestDoubleVect.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/cr6340864/TestFloatVect.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/cr6340864/TestIntVect.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/cr6340864/TestIntVectRotate.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/cr6340864/TestLongVect.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/cr6340864/TestLongVectRotate.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/cr6340864/TestShortVect.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/TestReplaceEquivPhis.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/TestShiftRightAndAccumulate.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/codegen/TestCharVect2.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/loopopts/superword/Vec_MulAddS2I.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/loopopts/TestUnswitchCloneSkeletonPredicates.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/loopstripmining/AntiDependentLoadInOuterStripMinedLoop.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/loopstripmining/LoadDependsOnIfIdenticalToLoopExit.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/loopstripmining/TestConservativeAntiDep.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/loopstripmining/TestEliminatedLoadPinnedOnBackedge.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/rangechecks/RangeCheckEliminationScaleNotOne.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/types/TestSubTypeCheckMacroNodeWrongMem.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/vectorization/TestVectorsNotSavedAtSafepoint.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
@King-kay
Copy link
Contributor

can i have this issue?

@sophia-guo
Copy link
Contributor Author

A few more tests have the same issue:
compiler/codegen/ClearArrayTest.java
compiler/c2/TestJumpTable.java
compiler/loopstripmining/TestPinnedUseInOuterLSMUnusedBySfpt.java
compiler/vectorapi/TestNoInline.java

@King-kay Could you also exclude those in #3006? Thanks!

@SehrishHussain
Copy link
Contributor

SehrishHussain commented Oct 22, 2021

Few more test for jdk18 windows_x86-32_:
compiler/c2/cr6340864/TestIntVectRotate.java.TestIntVectRotate
compiler/c2/cr6340864/TestLongVectRotate.java.TestLongVectRotate
compiler/c2/irTests/TestPostParseCallDevirtualization.java.TestPostParseCallDevirtualization
compiler/loopstripmining/TestPinnedUseInOuterLSMUnusedBySfpt.java.TestPinnedUseInOuterLSMUnusedBySfpt
compiler/tiered/TieredLevelsTest.java.TieredLevelsTest
compiler/vectorapi/TestNoInline.java.TestNoInline

Jenkins URL: https://ci.adoptopenjdk.net/job/Test_openjdk18_hs_extended.openjdk_x86-32_windows_testList_0/7/#showFailuresLink
TRSS Link: https://trss.adoptium.net/allTestsInfo?buildId=616d7c23c6182d021780002b&limit=5&hasChildren=true

@sophia-guo
Copy link
Contributor Author

@SehrishHussain the failures mentioned in #3004 (comment) is for jdk18.

@SehrishHussain
Copy link
Contributor

@sophia-guo sorry I missed to mention jdk18. Yes they are for jdk18

@sophia-guo
Copy link
Contributor Author

@SehrishHussain I noticed that you are updating jdk18 problem list, so probably just directly update that file.

@SehrishHussain
Copy link
Contributor

@sophia-guo Yes I have updated the file. Leaving a comment here because the tests were related to compiler tests mentioned here.

@smlambert
Copy link
Contributor

yes, hey @sophia-guo, I had requested Sehrish put comments into the existing issues, as it helps me and others know where things are failing and prevents issue "bloat" by not creating new github issues for failures that are same across platforms/versions.

sophia-guo pushed a commit that referenced this issue Oct 22, 2021
…ws-x86" (#3006)

* Update ProblemList_openjdk17.txt

* Update ProblemList_openjdk17.txt

Fix #3004

* Update ProblemList_openjdk17.txt

for windows-x86 platform

* Update ProblemList_openjdk17.txt

* Update ProblemList_openjdk17.txt

* Update ProblemList_openjdk17.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants