Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Release Summary Report logic #518

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Enhance Release Summary Report logic #518

merged 1 commit into from
Aug 12, 2021

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Jul 28, 2021 •
edited
Loading

  • Use Promise.all() to send queries in parallel to improve the performance
  • Remove unnecessary queries
  • Use params() to handle special characters in parameter values (i.e., test name)
  • Add title and Grid view link
  • Show actual build results instead of general message Test Job Failed
  • Add different icons for UNSTABLE and FAILURE
  • separate build and test build results into two different groups
  • Sort build names in the report, so Version/Impl/Platform and Parent/Child are grouped together
  • Handle errors
  • in the performance testing, we increased report generation time from 26 secs to 5 secs

Resolves: #501 and #506

Signed-off-by: lanxia lan_xia@ca.ibm.com

@llxia llxia added the enhancement New feature or request label Jul 28, 2021
@llxia
Enhance Release Summary Report logic
fae3431 
- Use Promise.all() to send queries in parallel to improve the performance
- Remove unnessary queries
- Use params() to handle special characters in parameter values (i.e., test name)
- Add title and Grid view link
- Sort build names in the report, so Version/Impl/Platform and Parent/Child are grouped together
- Handle errors

Resolves: adoptium#501 and adoptium#506

Signed-off-by: lanxia <lan_xia@ca.ibm.com>
@llxia
Copy link
Contributor Author

llxia commented Aug 11, 2021

image

@llxia llxia marked this pull request as ready for review August 11, 2021 19:36
@llxia llxia requested a review from smlambert August 11, 2021 19:39
@llxia
Copy link
Contributor Author

llxia commented Aug 11, 2021

image

smlambert
smlambert approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay, thank you!

@smlambert smlambert merged commit a861475 into adoptium:master Aug 12, 2021
@smlambert smlambert mentioned this pull request Sep 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Organize Release Report summary by Platform Parent/Child jobs
2 participants
@llxia @smlambert