Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase individual test timeout from 10 min to 20 min #395

Merged
merged 1 commit into from
Jan 23, 2021

Conversation

JasonFengJ9
Copy link
Contributor

@JasonFengJ9 JasonFengJ9 commented Jan 19, 2021

Each test's timeout limit is multiplied by the time factor value. One base time limit is 10 minutes, increase it to 20 minutes.
This is reflected by the timeoutSeconds value within jtr file.

Note: there were individual tests take slightly more than 10 min to finish in certain ppc64le_linux machines. Verified with this PR, the test in question passes in 10x grinder.

Signed-off-by: Jason Feng fengj@ca.ibm.com

Each test's timeout limit is multiplied by the time factor value. One
base time limit is 10 minutes, increase it to 20 minutes.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@JasonFengJ9
Copy link
Contributor Author

@Mesbah-Alam could you please review?

Copy link
Contributor

@Mesbah-Alam Mesbah-Alam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mesbah-Alam
Copy link
Contributor

@JasonFengJ9 : Approved. However, if this is not a fix for a defect, please defer merging this until after the release that is happening this week.

@JasonFengJ9
Copy link
Contributor Author

Thanks @Mesbah-Alam
No rush, it is to fix an internal test failure which is intermittent.

@karianna karianna added this to the January 2021 milestone Jan 20, 2021
@Mesbah-Alam Mesbah-Alam merged commit 7165bc1 into adoptium:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants