Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add case for os.arch equals 'arm' #88

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Add case for os.arch equals 'arm' #88

merged 2 commits into from
Jul 7, 2020

Conversation

smlambert
Copy link
Contributor

Fixes #18
Signed-off-by: Shelley Lambert slambert@gmail.com

@smlambert
os.arch for arm32 is 'arm'
7a9018d 
Signed-off-by: Shelley Lambert <slambert@gmail.com>
@smlambert
Copy link
Contributor Author

Leave in Draft as there is no machine online to verify this change.

https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder_TKG/1/

@smlambert smlambert mentioned this pull request Jun 28, 2020
Closed
@karianna karianna added the bug Something isn't working label Jun 29, 2020
@karianna karianna added this to the June 2020 milestone Jun 29, 2020
@karianna karianna added enhancement New feature or request and removed bug Something isn't working labels Jun 29, 2020
@karianna karianna modified the milestones: June 2020, July 2020 Jul 2, 2020
@smlambert
Unneeded brace
8e4b936 
Signed-off-by: Shelley Lambert <slambert@gmail.com>
@smlambert smlambert marked this pull request as ready for review July 7, 2020 13:27
@smlambert
Copy link
Contributor Author

smlambert commented Jul 7, 2020 •
edited
Loading

2 machines are now online so will relaunch some grinders:

@smlambert smlambert requested a review from renfeiw July 7, 2020 14:51
renfeiw
renfeiw approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@renfeiw renfeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renfeiw renfeiw merged commit da88ca4 into adoptium:master Jul 7, 2020
@smlambert smlambert deleted the arm32 branch February 22, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renfeiw renfeiw renfeiw approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
July 2020
Development

Successfully merging this pull request may close these issues.

Auto-detect does not work for arm 32 builds
3 participants
@smlambert @renfeiw @karianna