Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support defining range of jdk versions #390

Closed
renfeiw opened this issue Jan 18, 2023 · 1 comment · Fixed by #400
Closed

Support defining range of jdk versions #390

renfeiw opened this issue Jan 18, 2023 · 1 comment · Fixed by #400

Comments

@renfeiw
Copy link
Contributor

renfeiw commented Jan 18, 2023 •
edited
Loading

As per request from the dev team, we would like to add a mechanism to define range of jdk version.
For example:

<versions>
	<version>[8, 11]</version>
</versions>

We should also support this in the <disable> element.
For example:

<disable>
	<comment>disable version 11 to 17</comment>
	<version>[11, 17]</version>
</disable>
@renfeiw
Copy link
Contributor Author

renfeiw commented Jan 18, 2023

related: #165

renfeiw added a commit to renfeiw/TKG that referenced this issue Jan 30, 2023
@renfeiw
Support defining a range of jdk versions
352134c 
- update parser logic
- add testcase/example for jdk version
- add testcase/example for disable jdk version

Fixes: adoptium#390

Signed-off-by: renfeiw <renfeiw@ca.ibm.com>
renfeiw added a commit to renfeiw/TKG that referenced this issue Jan 30, 2023
@renfeiw
Support defining a range of jdk versions
b01dd16 
- update parser logic
- add testcase/example for jdk version
- add testcase/example for disable jdk version

Fixes: adoptium#390

Signed-off-by: renfeiw <renfeiw@ca.ibm.com>
renfeiw added a commit to renfeiw/TKG that referenced this issue Jan 31, 2023
@renfeiw
Support defining a range of jdk versions
ebcdee5 
- update parser logic
- add testcase/example for jdk version
- add testcase/example for disable jdk version
- add verbose option for tkg test

Fixes: adoptium#390

Signed-off-by: renfeiw <renfeiw@ca.ibm.com>
@renfeiw renfeiw mentioned this issue Feb 3, 2023
Merged
renfeiw added a commit to renfeiw/TKG that referenced this issue Feb 3, 2023
@renfeiw
Support defining a range of jdk versions
b1407c4 
- update parser logic
- add testcase/example for jdk version
- add testcase/example for disable jdk version
- add verbose option for tkg test

Fixes: adoptium#390

Signed-off-by: renfeiw <renfeiw@ca.ibm.com>
@smlambert smlambert mentioned this issue Feb 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support defining a range of jdk versions renfeiw/TKG
1 participant
@renfeiw