-
-
Notifications
You must be signed in to change notification settings - Fork 40
Description
Background
Windows platform's MAX_PATH restrictions have sporadically been causing STF based system tests to fail due to generated path lengths > MAX_PATH.
We have already been shortening some system test names as a fix.
However, to avoid such issues in future, we should investigate ways to optimize STF generated paths to keep them as short as possible.
Possible options to consider:
-
Timestamp: When STF based system tests are run coupled with TKG, there are two timestamp values added in the test paths-- one from TKG and one from STF (e.g.
F:/Users/jenkins/workspace/Test_openjdk11_j9_sanity.system_x86-64_windows_mixed_cm_Nightly_testList_1/openjdk-tests/\TKG\test_output_16076325439603\MauveSingleInvocationLoadTest_OpenJ9_0/20201210-145632-MauveSingleInvocationLoadTest/generation/generation.st). Could we remove the STF generated timestamp?
1.1) Pro: It gives us test paths with only one timestamp in TKG runs.
1.2) Con: It violates the STF use-case of running tests locally using system test make layer - when the STF generated timestamp is essential to distinguish between multiple runs of a particular test. -
STF appends the current tests's name after timestamp. This is useful when STF tests are run locally using the make layer, as we then get generated paths such as
/tmp/stf/20201215-130158-MixedLoadTest/- which clearly signify which test they belong to. However, when STF is used coupled with TKG (e.g. in Jenkins builds), we are already in a working directory that contains the test name, so the test folder name under that may not need the test name signifier again (e.g.,../MauveSingleInvocationLoadTest_OpenJ9_0/20201210-145632-MauveSingleInvocationLoadTest- which is unnecessary). Can we simply not append the test name in stf.pl ?
2.1) Pro: This gives us a shorter path in Jenkins runs.
2.2) Con: This means the local run using system test make layer would end up with paths without test name in them (e.g./tmp/stf/20201215-130158).