Prefer moment's localeData methods #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_months`, `_weekdays`, and `_weekdaysShort` properties suggested in the readme are internal momentjs methods. Using the external versions of those (e.g. `months()`) is less prone to bugs.
|
great find @drouhard ! Generally we like tests to assert behavior but given the nature of this change, I think that is unnecessary. One should always prefer public, documented API behavior instead of those quiet lurking |
ghost
merged commit 
ghost
added
the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_months,_weekdays, and_weekdaysShortproperties suggested in the readme are internal moment.js methods. Using documented, external versions of those (e.g.months()) is less prone to regressions.This fixes #222 : months show as 'undefined' in Russian