Skip to content

Is ember-cli-moment-shim still required for ember-moment? #369

Open
@rreckonerr

Description

Hi! Thanks for taking care of this addon!
I wonder whether the https://github.com/jasonmit/ember-cli-moment-shim is still required for ember-moment?

In case it DOES NOT, should we remove the blueprint?

In case it DOES, should we update ember-cli-moment-shim to the latest v3.8.0 in the blueprint?

ember-cli-moment-shim v3.4.0 is a blocker for upgrading to the latest ember versions since it relies on ember-cli-babel@6.6.0.

ATM I upgraded to the latest ember-moment v9.0.1, removed ember-cli-moment-shim, and don't see any downsides so far.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions