Update Segment's loading snippet #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran `prettier --write segment-snippet`
I took it from more recent Segment documentation. This small snippet is versioned. These changes upgrade it from 2.0.9 to 4.1.0
|
@dcyriller Thanks for this Cyrille! I added you as a collaborator. Once you merge this, LMK and I'll add you on npm as well so you can publish :) |
|
Thank you Lauren! :) |
|
@poteto I'm ready to release! I'm thinking of using lerna-changelog to generate a Changelog. I could configure it if you agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR, I propose to upgrade Segment's loading snippet (and only the snippet, not the library itself).
The currently loading snippet is taken from an old version of Segment's documentation. I took this one from more recent Segment documentation. This small snippet is versioned. The proposed changes upgrade it from
2.0.9to4.1.0.To ease the review, I have prettyfied the snippet in a first commit. So that you can review - if you'd like - the snippet itself by comparing the first and the second commit.
Note that I have been using it in production for roughly two years (on a fork that I'm trying to remove 😄).
Why
The main change to this snippet is that Segment library will support two new methods:
resetanddebug.It loads the same library than before from
http://cdn.segment.com/analytics.js/v1/${segmentKey}/analytics.min.js.