Replace canUseDOM with Adapter.supportsFastboot. #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this merge? |
|
fwiw I've been using it in a production app for the last 11 weeks. |
|
Yeah, I reviewed the commit and then booted my app with it and it's good to go IMO. @poteto needs to merge though |
|
Fixed new merge conflicts. |
|
Rebased |
|
I believe we don't need this anymore. I have been using this addon with fastboot without any issues. Can you confirm we can close this @CvX? |
Implementation of an idea in adopted-ember-addons#162 by @kellyselden
josemarluedke
approved these changes
Aug 26, 2019
This was referenced Aug 26, 2019
Closed
ndekeister-us
added a commit
to peopledoc/ember-metrics-pendo
that referenced
this pull request
Feb 19, 2021
ndekeister-us
added a commit
to peopledoc/ember-metrics-pendo
that referenced
this pull request
Feb 22, 2021
ndekeister-us
added a commit
to peopledoc/ember-metrics-pendo
that referenced
this pull request
Feb 22, 2021
* build: use last version of ember-metrics * refactor: remove use of canUseDOM See adopted-ember-addons/ember-metrics#175 * refactor: use removeFromDOM util * fix: tests failing because assert import is not done * refactor: use native class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of an idea in #162 by @kellyselden
Fixes ember-metrics errors in Fastboot, like
TypeError: window.ga is not a function(since Fastboot does provide DOM-like environment but ember-metrics still tried to load adapters).