Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap qs for neoqs #1048

Open
wants to merge 1 commit into
base: 21.x
Choose a base branch
from
Open

Conversation

mattstrayer
Copy link

Followup from -> adonisjs/bodyparser#65

πŸ”— Linked issue

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@@ -7,7 +7,7 @@
* file that was distributed with this source code.
*/

import { stringify } from 'qs'
import { stringify } from 'neoqs'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case lucid ships with CJS, this should be neoqs/legacy

@RomainLanz
Copy link
Member

Thanks for your PR!

We discussed this internally, and we would prefer not to migrate to neoqs as of now. But we keep the PR open for further discussion.

The main reason is that qs is a critical part of AdonisJS, and this new package may not fit all use cases or keep up with the qs package.

Also, migrating to a brand new package may add more vulnerability since we don't know well the author nor its future intention.

If we want to debloat qs, we would prefer to make our own version under the BoringNode organization.

Related PRs are:

@RomainLanz RomainLanz added the Status: On Hold The work was started earlier, but is on hold now. Check comments for reasoning label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: On Hold The work was started earlier, but is on hold now. Check comments for reasoning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants