Skip to content

Conversation

@andrewbrey
Copy link
Contributor

@andrewbrey andrewbrey commented Sep 22, 2024

πŸ”— Linked issue

Fixes #2

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add JSDoc type information for the configBlocksToMerge parameter of both configPkg and configApp. Doing this greatly improves the autocomplete experience for users who wish to override any part of the base config.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@thetutlage thetutlage merged commit 42aeb82 into adonisjs:v2 Sep 22, 2024
@thetutlage
Copy link
Member

Thanks for the PR πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing type information for config blocks

2 participants