Unavoidable errors when DB response is null

[ndianabasi]

Prerequisites

I've noticed a persistent and unavoidable error when DB response is null. In a typical usage of the addon, not all attachment column will return the expected format which is parse-able by the add-on. Some columns will contain null values. The add-on current fails when null values are encountered.

The issue can be traced to these lines:

attachment-lite/src/Attachment/index.ts

Lines 64 to 75 in 4f05e55

	const attributes = typeof response === 'string' ? JSON.parse(response) : response
	/**
	* Validate the db response
	*/
	REQUIRED_ATTRIBUTES.forEach((attribute) => {
	if (attributes[attribute] === undefined) {
	throw new Exception(
	`Cannot create attachment from database response. Missing attribute "${attribute}"`
	)
	}
	})

When attributes is null, the Array.forEach call fails. A suggestion is for the add-on to provide a no-op when null is encountered.

Package version

1.0.1

Node.js and npm version

Node: 14.18.2. NPM: 6.14.15

Sample Code (to reproduce the issue)

attachment-lite/src/Attachment/index.ts

Lines 64 to 75 in 4f05e55

	const attributes = typeof response === 'string' ? JSON.parse(response) : response
	/**
	* Validate the db response
	*/
	REQUIRED_ATTRIBUTES.forEach((attribute) => {
	if (attributes[attribute] === undefined) {
	throw new Exception(
	`Cannot create attachment from database response. Missing attribute "${attribute}"`
	)
	}
	})

BONUS (a sample repo to reproduce the issue)

[thetutlage]

Yeah we can ignore explicit null values to allow nullable columns