chore(console): remove debug console.log in subscription flow#24
chore(console): remove debug console.log in subscription flow#24
Conversation
- Add image compression when clipboard images exceed 4MB (API limit is 5MB) - Use ImageMagick for progressive compression (quality 85→30, resize 100%→25%) - Convert oversized PNGs to optimized JPEGs - Graceful fallback if ImageMagick unavailable fix(provider): allow instructions param for Codex API - Add "instructions" to OpenAI supported params whitelist - Fixes "Instructions are required" error with gpt-5.2-codex Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove leftover debug logging that was printing setupIntent to console.
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05854a10ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| try { | ||
| process.kill(existing.pid, 0) | ||
| throw new Error(`Daemon is already running (PID: ${existing.pid})`) | ||
| } catch { | ||
| // Stale lock |
There was a problem hiding this comment.
The try/catch around process.kill(existing.pid, 0) swallows the deliberately thrown "Daemon is already running" error, so any live PID is treated as a stale lock and the code proceeds to recreate the lock. In practice this means if the PID file was removed (e.g., during the restart flow where you delete the PID file before starting a new daemon), acquireLock() will still succeed even though the old daemon is still running, allowing two daemons to run concurrently and contend for ports/state. You likely want to only catch process.kill failures (e.g., ESRCH) and rethrow when the PID is alive.
Useful? React with 👍 / 👎.
2 participants
Remove leftover debug logging that was printing setupIntent to console during subscription checkout.