Conversation
Use semver range (^1.3.5) instead of exact match so newer compatible Bun versions work without failing the build script. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ba955bf4c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import { $ } from "bun" | ||
| import path from "path" | ||
| import { satisfies } from "semver" |
There was a problem hiding this comment.
The new import { satisfies } from "semver" is in the packages/agent-core package, but semver is only added to the root package.json. Following the package’s own instructions (packages/agent-core/AGENTS.md says bun install from that directory), bun run build will fail with a module-not-found error because packages/agent-core/package.json does not declare semver (or @types/semver). This breaks local builds unless you install at the repo root; consider adding the dependency to packages/agent-core so package-local installs work.
Useful? React with 👍 / 👎.
1 participant
Summary
semver.satisfies()with^range instead of exact string match for Bun version check in the build scriptsemver+@types/semveras dev dependenciesCloses #222
Test plan
bun installresolves cleanlybun run buildsucceeds./script/verify-binary.shpassesbun@^1.3.5) when version is incompatibleGenerated with Claude Code