Conversation
* Update Lr splash screen path Resolves: [MWPW-180571](https://jira.corp.adobe.com/browse/MWPW-180571) **Test URLs:** - Before: https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=stage&martech=off - After: https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=lr-splashscreen&martech=off
* Add support for lightroom workflow * Add common util file for file chunking * Unit tests * Nala Tests Resolves: [MWPW-180571](https://jira.corp.adobe.com/browse/MWPW-180571) **Test URLs:** - Before: https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=stage&martech=off - After: https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=MWPW-180571&martech=off **Testing Notes:** **Lightroom testing** 1. Test with various size of jpeg files and make when the file is greater than 10 MB file is uploaded in chunks 2. File type supported is jpeg/jpg 3. Max size supported is 40 MB 4. If you get 403 when landing on the product page please open this url in browser in another tab https://f0.lightroom.adobe.com/tkt/#magic=split-rocker 5. Clear your cookies and test in normal window and not in incognito. We are seeing some issue on product page when testing incognito. 6. This is going to be a desktop only feature. Authors will most likely achieve it by using MEP **Photoshop Testing:** 1. As this PR is touching the code for workflow-upload, please do a regression PS workflow too Authoring Documentation: https://wiki.corp.adobe.com/display/adobedotcom/CC+Upload+Configurator+for+Lightroom
…585) Update code to make function names generic as this workflow will now be used for products other Photoshop. Following was updated: * Renamed psApiConfig → apiConfig * Renamed getPsApiConfig() → getApiConfig() * Renamed unityConfig.psEndPoint → unityConfig.endPoint * Renamed photoshopActionMaps() → executeActionMaps() * Updated product tag resolution to use configuration-driven approach from target-config.json for Lana logging * All API endpoint references updated throughout the files * Added additional analytics event for failures once uploading has started * Increase unit test coverage (workflow-upload - 94.68% , action-binder.js - 93.38%, upload-handler.js - 100% <img width="1432" height="438" alt="Screenshot 2025-10-16 at 10 46 05 PM" src="https://github.com/user-attachments/assets/28aab761-12aa-4768-8413-9cfae272eb44" /> Resolves: [MWPW-180571](https://jira.corp.adobe.com/browse/MWPW-180571) **Test URLs:** - Before: https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=stage&martech=off - After: https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=lightroom-refactor&martech=off --------- Co-authored-by: Arushi Gupta <65466846+arugupta1992@users.noreply.github.com> Co-authored-by: rohitsahu <sahurohit9@gmail.com> Co-authored-by: Rohit Sahu <rosahu@adobe.com> Co-authored-by: Arushi Gupta <arugupta@arushis-mbp.corp.adobe.com> Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local> Co-authored-by: Vipul Gupta <vipugpta@gmail.com> Co-authored-by: sigadamramesh <130433161+sigadamvenkata@users.noreply.github.com> Co-authored-by: Santoshkumar Nateekar <santoshkumar.sn@gmail.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com>
* Fix browser default behavior when image is drop outside of drop zone * Don't let any drop happen outside of drop zone so that image doesn't open in the whole browser taking over the page. Resolves: [MWPW-182449](https://jira.corp.adobe.com/browse/MWPW-182449) **Test URLs:** - Before: https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=stage&martech=off - After: https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=drag-n-drop&martech=off
…or (#616) * Fix duplicate analytics event being sent when server error Resolves: [MWPW-180571](https://jira.corp.adobe.com/browse/MWPW-180571) **Test URLs:** - Before: https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=stage - After: https://main--cc--adobecom.aem.live/drafts/ruchika/unity/lightroom/lightroom?unitylibs=lr-analytics - Before: https://main--cc--adobecom.aem.live/products/photoshop/online?unitylibs=stage - After: https://main--cc--adobecom.aem.live/products/photoshop/online?unitylibs=lr-analytics Note: this issue existed for both PS and Lr
* Update lightroom splash screen path Resolves: [MWPW-180571](https://jira.corp.adobe.com/browse/MWPW-180571) **Test URLs:** - Before: https://main--cc--adobecom.aem.page/drafts/ruchika/unity/lightroom/lightroom?unitylibs=stage&martech=off - After: https://main--cc--adobecom.aem.page/drafts/ruchika/unity/lightroom/lightroom?unitylibs=lightroom-splashscreen&martech=off
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Collaborator
Author
|
Lightroom nala tests are failing because transition screen for Lr is not published yet. |
* We will not be localizing model-picker file an load model-picker file from US path for all locales Resolves: [MWPW-183196](https://jira.corp.adobe.com/browse/MWPW-183196) **Test URLs:** - Before: https://main--cc--adobecom.aem.page/products/firefly?martech=off&unitylibs=stage - After: https://main--cc--adobecom.aem.page/products/firefly?martech=off&unitylibs=MWPW-183196 - Before: https://main--cc--adobecom.aem.page/uk/drafts/ruchika/firefly?unitylibs=stage - After: https://main--cc--adobecom.aem.page/uk/drafts/ruchika/firefly?unitylibs=MWPW-183196
arugupta1992
approved these changes
Oct 31, 2025
vipu0303
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRs
Test URLs:
Lightroom
Photoshop (for regression only)