[MWPW-182688] MAX - Addressing tab focus issues.#605
Closed
[MWPW-182688] MAX - Addressing tab focus issues.#605
Conversation
Ruchika4
requested changes
Oct 24, 2025
arugupta1992
approved these changes
Oct 24, 2025
arugupta1992
pushed a commit
that referenced
this pull request
Oct 24, 2025
…esign branch (#609) Pulling these 2 PRs to be pushed to ff redesign branch for max firefly testing #604 #605 # 604 Addressing design feedback on prompt bar Added shadow to prompt bar. Increased corner radius on image/video (verb) drop down Adjusted padding and gap to reduce the height of the prompt bar to better match Figma. Added authoring ability to hide video models if needed. Note, this might not be needed but was added just in case for a quick authoring adjustment. Note on authoring feature: Adding hide-video-models as a variant to the Unity, Showcase or Hero blocks will hide video models. Resolves: [MWPW-NUMBER](https://jira.corp.adobe.com/browse/MWPW-NUMBER) Test URLs: Before: https://main--cc--adobecom.aem.page/drafts/rclayton/firefly/prompt-max?unitylibs=stage&martech=off After: https://main--cc--adobecom.aem.page/drafts/rclayton/firefly/prompt-max?unitylibs=max-prompt-design-feedback&martech=off MAX Test URLs: Before: https://max-ff-redesign--cc--adobecom.aem.page/drafts/jingle/firefly-max?milolibs=max25-theme&unitylibs=stage&martech=off After: https://max-ff-redesign--cc--adobecom.aem.page/drafts/jingle/firefly-max?milolibs=max25-theme&unitylibs=max-prompt-design-feedback&martech=off # 605 Fixes focus trap and tab focus issues [reported in Slack](https://adobe-mwp.slack.com/archives/C09MVV1NBE0/p1761257532527809). Resolves: [MWPW-182688](https://jira.corp.adobe.com/browse/MWPW-182688) **Test URLs:** - Before: https://main--unity--adobecom.aem.page/?martech=off - After: https://<branch>--unity--adobecom.aem.page/?martech=off --------- Co-authored-by: Ryan Clayton <rclayton@adobe.com>
rgclayton
pushed a commit
that referenced
this pull request
Oct 24, 2025
…esign branch (#609) Pulling these 2 PRs to be pushed to ff redesign branch for max firefly testing #604 #605 # 604 Addressing design feedback on prompt bar Added shadow to prompt bar. Increased corner radius on image/video (verb) drop down Adjusted padding and gap to reduce the height of the prompt bar to better match Figma. Added authoring ability to hide video models if needed. Note, this might not be needed but was added just in case for a quick authoring adjustment. Note on authoring feature: Adding hide-video-models as a variant to the Unity, Showcase or Hero blocks will hide video models. Resolves: [MWPW-NUMBER](https://jira.corp.adobe.com/browse/MWPW-NUMBER) Test URLs: Before: https://main--cc--adobecom.aem.page/drafts/rclayton/firefly/prompt-max?unitylibs=stage&martech=off After: https://main--cc--adobecom.aem.page/drafts/rclayton/firefly/prompt-max?unitylibs=max-prompt-design-feedback&martech=off MAX Test URLs: Before: https://max-ff-redesign--cc--adobecom.aem.page/drafts/jingle/firefly-max?milolibs=max25-theme&unitylibs=stage&martech=off After: https://max-ff-redesign--cc--adobecom.aem.page/drafts/jingle/firefly-max?milolibs=max25-theme&unitylibs=max-prompt-design-feedback&martech=off # 605 Fixes focus trap and tab focus issues [reported in Slack](https://adobe-mwp.slack.com/archives/C09MVV1NBE0/p1761257532527809). Resolves: [MWPW-182688](https://jira.corp.adobe.com/browse/MWPW-182688) **Test URLs:** - Before: https://main--unity--adobecom.aem.page/?martech=off - After: https://<branch>--unity--adobecom.aem.page/?martech=off --------- Co-authored-by: Ryan Clayton <rclayton@adobe.com>
sanjayms01
pushed a commit
that referenced
this pull request
Oct 24, 2025
max-ff-redesign PR's to stage * #608 * #605 * #604 * #610 Resolves: [MWPW-NUMBER](https://jira.corp.adobe.com/browse/MWPW-NUMBER) **Test URLs:** - Before: https://main--unity--adobecom.aem.page/?martech=off - After: https://<branch>--unity--adobecom.aem.page/?martech=off
Contributor
Author
|
Closing. These were merged into max-ff-redesign and that branch was merged to stage. |
sanjayms01
pushed a commit
that referenced
this pull request
Oct 24, 2025
max-ff-redesign PR's to stage * #608 * #605 * #604 * #610 Resolves: [MWPW-NUMBER](https://jira.corp.adobe.com/browse/MWPW-NUMBER) **Test URLs:** - Before: https://main--unity--adobecom.aem.page/?martech=off - After: https://<branch>--unity--adobecom.aem.page/?martech=off
sanjayms01
pushed a commit
that referenced
this pull request
Oct 24, 2025
max-ff-redesign PR's to stage * #608 * #605 * #604 * #610 Resolves: [MWPW-NUMBER](https://jira.corp.adobe.com/browse/MWPW-NUMBER) **Test URLs:** - Before: https://main--unity--adobecom.aem.page/?martech=off - After: https://<branch>--unity--adobecom.aem.page/?martech=off
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes focus trap and tab focus issues reported in Slack.
Resolves: MWPW-182688
Test URLs:
MAX Test URLs: