MWPW-186818 [Project Lingo] Segment Merch card variant in M@S Studio#567
MWPW-186818 [Project Lingo] Segment Merch card variant in M@S Studio#567bozojovicic wants to merge 12 commits intomainfrom
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
|
There was a problem hiding this comment.
@bozojovicic Plz review these:
https://main--milo--adobecom.aem.page/drafts/bozo/pr/segment-coll?maslibs=mwpw-186818
- Theres hardly no padding below the heading or above the price element in Milo example:
https://main--cc--adobecom.aem.page/products/dreamweaver
In current we have a padding.
2)Is it not better have a font weight of 400 for Badge text ? as in Plans variant.
- Links on Production have color: rgb(44, 44, 44) and in current its rgb(39, 77, 234)
4)Tooltip for callout text is always visible, ideally it should be on hover over and should not go outside the card border
5)Observed some Accessibility issues:
The Links and buttons should have unique/descriptive aria-labels and daa-ll values:
Expected like in Milo:
aria-label="See what's included in Creative Cloud Pro"
daa-ll="See what s included-1--Creative Cloud ProUS 69 99 mo"
aria-label="Buy now - Creative Cloud Pro - Individuals"
daa-ll="Buy now-3--Creative Cloud ProUS 69 99 mo"

Resolves https://jira.corp.adobe.com/browse/MWPW-186818
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
MAS Studio https://mwpw-186818--mas--adobecom.aem.live/studio.html#fragmentId=e51014d2-4a03-4e69-8b44-417d315d43a5&page=fragment-editor&path=sandbox
Cards on Milo pages :
Collection https://main--milo--adobecom.aem.page/drafts/bozo/pr/segment-coll?maslibs=mwpw-186818
Single cards https://main--milo--adobecom.aem.page/drafts/bozo/pr/segment-cards?maslibs=mwpw-186818
Milo example from prod : https://main--cc--adobecom.aem.page/cc-shared/fragments/merch/products/dreamweaver/merch-card/segment-blade?maslibs=mwpw-186818
No figma for this card, I implemented it as on kitchen sink, see the bottom of the page
https://stage--milo--adobecom.aem.page/merch/kitchen-sink?martech=off
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: