MWPW-185783: Design QA Part 2 - Full Pricing Express Card Width #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed full-pricing-express cards not filling viewport width on mobile and tablet. Cards were constrained by Milo's .content max-width and .collection-container grid layout. Changes: - Added mobile media query (max-width: 767px) to override Milo constraints - Added tablet media query rules to override .collection-container grid - Changed padding from 40px to 16px on mobile/tablet per design spec - Changed mobile/tablet breakpoint from 1024px to 1199px - Additional design QA fixes for simplified-pricing-express and mas-mnemonic
Axelcureno
force-pushed
the
MWPW-185783
branch
from
1df48bc to
51985b2
Compare
seanchoi-dev
approved these changes
Jan 30, 2026
| merch-card[variant="full-pricing-express"] span[is="inline-price"][data-template='strikethrough'] .price, | ||
| merch-card[variant="full-pricing-express"] span[is="inline-price"][data-template='price'] .price-strikethrough { | ||
| color: var(--spectrum-gray-500); | ||
| color: #8F8F8F; |
Contributor
There was a problem hiding this comment.
I was wondering if we could use an existing color variable instead.
In Figma, it’s using “Palette/gray/500” (#8f8f8f), but I’m not sure where this value is coming from.
In the long term, if we keep using arbitrary colors, the overall look of the site may feel less polished.
| padding: 24px 16px; | ||
| border-radius: var(--merch-card-full-pricing-express-price-radius); | ||
| border: 1px solid #e0e2ff; | ||
| border: 1px solid #d5d5d5; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://jira.corp.adobe.com/browse/MWPW-185783
Fixed full-pricing-express cards not filling viewport width on mobile and tablet. Cards were constrained by Milo's
.contentmax-width and.collection-containergrid layout.Changes:
.collection-containergridTest URLs:
Checklist: