MWPW-186041 and MWPW-185791 Spectrum icon library for card badge and what's included#526
Open
bozojovicic wants to merge 20 commits intomainfrom
Open
MWPW-186041 and MWPW-185791 Spectrum icon library for card badge and what's included#526bozojovicic wants to merge 20 commits intomainfrom
bozojovicic wants to merge 20 commits intomainfrom
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
|
Roycethan
reviewed
Feb 2, 2026
Collaborator
Roycethan
left a comment
There was a problem hiding this comment.
- Plz resolve the conflicts.
- Plz confirm on the mobile design which i commented here if its good or not
https://jira.corp.adobe.com/browse/MWPW-185791?focusedId=52447863&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-52447863
Contributor
Author
|
@Roycethan I'm waiting for an answer from Lucy/Fred regarding that "see more" on mobile. Once they decide how that should work I will fix it and also fix the conflicts. |
joaquinrivero
approved these changes
Feb 3, 2026
Blainegunn
approved these changes
Feb 4, 2026
antonio-rmrz
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://jira.corp.adobe.com/browse/MWPW-186041 and
https://jira.corp.adobe.com/browse/MWPW-185791
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
What is implemented here? For plans pages, now we can add the spectrum icon to the card badge and also the section "What's included" is extended with bullet points where we can set spectrum icons instead of product icons. In both places the new "spectrum icon library" is used with Spectrum 1 icons. It will be extended in the future with more icons for other components.
For bullet points in "What's included" we also need to add the text for every bullet and that text can contain links, that's why RTE is used. We can still use SVG files and the URL can be set in the URL tab in the icon library.
Test pages :
https://mwpw-186041--mas--adobecom.aem.live/studio.html#fragmentId=167a3618-d5fd-42c3-a2ff-9cb7bc601638&page=fragment-editor&path=sandbox
https://mwpw186041--milo--bozojovicic.aem.page/drafts/bozo/icon/icons-coll?maslibs=MWPW-186041
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: