Merged
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
apganapa-adobe
approved these changes
Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Configuration Management to Centralized Assets
Overview
This PR refactors the configuration management system to use centralized, multi-sheet JSON files hosted in the content repository, replacing the previous distributed approach. The changes simplify configuration management and improve maintainability across the event-libs codebase.
Key Changes
1. Dictionary Manager Refactoring ✨
placeholders.jsonfetches per sheet to a single multi-sheetdictionary.jsonfetchaddSheet({ config, sheet })toinitialize()- one call loads all sheetsgetValue(key, sheet)to default to 'data' sheet (was 'default')${domain}${prefix}/event-libs/assets/configs/dictionary.jsonimport.meta.urlto determine domain dynamically instead of requiring config2. RSVP Configuration Refactoring 🔧
/event-libs/assets/configs/rsvp/{cloud-type}.jsongetRsvpConfigUrl()helper that usesimport.meta.urlfor domain resolutionrsvp-config-locationmetadata and SP-specific logic3. Promotional Content Refactoring 🎯
/event-libs/assets/configs/promotional-content.jsongetPromotionalContentUrl(): Helper function for consistent URL construction usingimport.meta.url4. RSVP Button Improvements 🐛
data-rsvp-initializedflag to prevent duplicate event handlersdata-rsvp-original-text: Persists original text in dataset for reliable restoration5. CSS Enhancements 🎨
Added new styles for RSVP buttons:
6. Code Cleanup 🧹
decorateEventimport from chrono-box7. Documentation Updates 📚
Updated
dictionary-manager-consolidation.mdwith:Migration Path
Before:
After:
Testing
dictionary-manager.test.jswith comprehensive tests for:Breaking Changes
/event-libs/assets/configs/dictionary.json(multi-sheet format)/event-libs/assets/configs/rsvp/{cloudtype}.json/event-libs/assets/configs/promotional-content.jsonPerformance Improvements
Files Changed
event-libs/v1/utils/dictionary-manager.js- Core refactoringevent-libs/v1/blocks/events-form/events-form.js- RSVP config updatesevent-libs/v1/blocks/promotional-content/promotional-content.js- Config path updatesevent-libs/v1/utils/decorate.js- Dictionary initialization and button handlingevent-libs/v1/libs-styles.css- New RSVP button stylestest/unit/scripts/dictionary-manager.test.js- Updated testsdocs/dictionary-manager-consolidation.md- Documentation updatesStats
Test URLs: