Skip to content

Conversation

@echen-adobe
Copy link
Contributor

@echen-adobe echen-adobe commented Dec 18, 2025

Summary

Briefly describe the features or fixes introduced in this PR.

Creates a sharable function for injection icons into marquee blocks. This function accounts for cases where the marquee is not the first block.

Also includes an escape hatch class to force icon injection.


Jira Ticket

Resolves: https://jira.corp.adobe.com/browse/MWPW-184504


Test URLs

Env URL
Before https://main--da-express-milo--adobecom.aem.page/express/
After https://general-icon-injection--da-express-milo--adobecom.aem.page/express/business
After https://general-icon-injection--da-express-milo--adobecom.aem.page/express/photos
After https://general-icon-injection--da-express-milo--adobecom.aem.page/express/create/calendar
After https://general-icon-injection--da-express-milo--adobecom.aem.page/docs/library/kitchen-sink/grid-marquee
After https://general-icon-injection--da-express-milo--adobecom.aem.page/docs/library/kitchen-sink/fullscreen-marquee

Verification Steps

  • Steps to reproduce the issue or view the new feature.
  • What to expect before and after the change.
  • Visit the page and ensure that the marquees look correct with and without mep

Potential Regressions

| Headline | https://general-icon-injection--da-express-milo--adobecom.aem.page/express/business |
| **AX Columns Fullsize ** | https://general-icon-injection--da-express-milo--adobecom.aem.page/express/photos |
| AX Columns Marquee | https://general-icon-injection--da-express-milo--adobecom.aem.page/express/create/calendar |
| Grid Marquee | https://general-icon-injection--da-express-milo--adobecom.aem.page/docs/library/kitchen-sink/grid-marquee |
| Fullscreen Marquee | https://general-icon-injection--da-express-milo--adobecom.aem.page/docs/library/kitchen-sink/fullscreen-marquee |


Additional Notes

(If applicable) Add context, related PRs, or known issues here.

@aem-code-sync
Copy link

aem-code-sync bot commented Dec 18, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync aem-code-sync bot temporarily deployed to general-icon-injection December 18, 2025 18:04 Inactive
@echen-adobe echen-adobe changed the title init Generalized Icon Injection Dec 18, 2025
@aem-code-sync
Copy link

aem-code-sync bot commented Dec 18, 2025

@nateyolles nateyolles added this to the Express-26.3 milestone Dec 18, 2025
@aem-code-sync aem-code-sync bot temporarily deployed to general-icon-injection December 19, 2025 18:56 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to general-icon-injection December 19, 2025 19:06 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to general-icon-injection December 19, 2025 19:08 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to general-icon-injection January 5, 2026 18:29 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to general-icon-injection January 5, 2026 18:50 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to general-icon-injection January 5, 2026 20:50 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to general-icon-injection January 5, 2026 21:40 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to general-icon-injection January 5, 2026 21:54 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to general-icon-injection January 5, 2026 22:05 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to general-icon-injection January 5, 2026 22:25 Inactive
@echen-adobe echen-adobe marked this pull request as ready for review January 5, 2026 23:30
@echen-adobe echen-adobe added the Ready for Review Ready for peer review. label Jan 5, 2026
const LOGO = 'adobe-express-logo';
const LOGO_WHITE = 'adobe-express-logo-white';

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove JDOCs and comments. You can create a technical guide page on the wiki section for the block / utils here instead:
https://github.com/adobecom/da-express-milo/wiki

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had started on this path on the previous Repo: https://github.com/adobecom/express-milo/wiki/Picker-(widget)
We can be as specific and as detailed as we wish there. Feel free to document as much as you see fit.

Copy link
Contributor

@yeibercano yeibercano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move comments and JSDOC to technical guide on wiki instead.

Copy link
Contributor

@fullcolorcoder fullcolorcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with docs comment, but code looks good

@aem-code-sync aem-code-sync bot temporarily deployed to general-icon-injection January 6, 2026 21:03 Inactive
@echen-adobe echen-adobe requested a review from yeibercano January 6, 2026 22:14
@yeibercano yeibercano added Ready for QA and removed Ready for Review Ready for peer review. labels Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants