-
Notifications
You must be signed in to change notification settings - Fork 2
Generalized Icon Injection #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stage
Are you sure you want to change the base?
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
express/code/scripts/utils.js
Outdated
| const LOGO = 'adobe-express-logo'; | ||
| const LOGO_WHITE = 'adobe-express-logo-white'; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove JDOCs and comments. You can create a technical guide page on the wiki section for the block / utils here instead:
https://github.com/adobecom/da-express-milo/wiki
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had started on this path on the previous Repo: https://github.com/adobecom/express-milo/wiki/Picker-(widget)
We can be as specific and as detailed as we wish there. Feel free to document as much as you see fit.
yeibercano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move comments and JSDOC to technical guide on wiki instead.
fullcolorcoder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with docs comment, but code looks good
Summary
Briefly describe the features or fixes introduced in this PR.
Creates a sharable function for injection icons into marquee blocks. This function accounts for cases where the marquee is not the first block.
Also includes an escape hatch class to force icon injection.
Jira Ticket
Resolves: https://jira.corp.adobe.com/browse/MWPW-184504
Test URLs
Verification Steps
Potential Regressions
| Headline | https://general-icon-injection--da-express-milo--adobecom.aem.page/express/business |
| **AX Columns Fullsize ** | https://general-icon-injection--da-express-milo--adobecom.aem.page/express/photos |
| AX Columns Marquee | https://general-icon-injection--da-express-milo--adobecom.aem.page/express/create/calendar |
| Grid Marquee | https://general-icon-injection--da-express-milo--adobecom.aem.page/docs/library/kitchen-sink/grid-marquee |
| Fullscreen Marquee | https://general-icon-injection--da-express-milo--adobecom.aem.page/docs/library/kitchen-sink/fullscreen-marquee |
Additional Notes
(If applicable) Add context, related PRs, or known issues here.