Remove Instances of first-of-type selectors
#42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit ba3fb90 Author: Eric Chen <159481679+echen-adobe@users.noreply.github.com> Date: Thu Dec 4 13:37:38 2025 -0600 updated selectors for template-x removed usage of div first child, last child, first of type, last of type
commit c95aaca1da09e33513f9c601c98cefde15264804
Author: Eric Chen <159481679+echen-adobe@users.noreply.github.com>
Date: Fri Dec 5 10:37:31 2025 -0600
Update quotes.js
commit ef2ec70
Merge: de89a62 e1d0bd2
Author: Haris Bijli <all46558@adobe.com>
Date: Thu Dec 4 10:59:56 2025 -0800
Merge pull request #808 from adobecom/test-gen-blocks
Test gen blocks
commit e1d0bd2
Merge: 66b62bf de89a62
Author: Haris Bijli <all46558@adobe.com>
Date: Thu Dec 4 09:22:28 2025 -0800
Merge branch 'stage' into test-gen-blocks
commit 66b62bf
Merge: 4e6feae c977780
Author: Haris Bijli <all46558@adobe.com>
Date: Thu Dec 4 05:27:13 2025 -0800
additional blocks and merge with stage
commit 4e6feae
Author: Haris Bijli <all46558@adobe.com>
Date: Tue Dec 2 13:37:38 2025 -0800
link-list-v2 and pricing-table
commit 190f25c
Author: Haris Bijli <all46558@adobe.com>
Date: Sun Nov 30 20:23:05 2025 -0800
more blocks
commit 3183867
Author: Haris Bijli <all46558@adobe.com>
Date: Thu Nov 20 08:46:42 2025 -0800
new blocks:
commit a4ad610
Merge: aecbecc e80982c
Author: Haris Bijli <all46558@adobe.com>
Date: Fri Nov 14 23:27:56 2025 -0800
Merge branch 'stage' into test-gen-blocks
merge from stage
commit aecbecc
Merge: 0a7fc96 b6e14f1
Author: Haris Bijli <all46558@adobe.com>
Date: Thu Nov 13 15:15:20 2025 -0800
Merge branch 'stage' into test-gen-blocks
commit 0a7fc96
Merge: cd17dd0 5c1475d
Author: Haris Bijli <all46558@adobe.com>
Date: Thu Nov 13 14:27:03 2025 -0800
Merge branch 'stage' into test-gen-blocks
commit cd17dd0
Author: Haris Bijli <all46558@adobe.com>
Date: Thu Nov 13 12:44:29 2025 -0800
test-gen blocks
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
yeibercano
reviewed
Jan 12, 2026
| block.querySelector('.column')?.prepend(logo); | ||
| } | ||
| } | ||
| const sections = Array.from(document.querySelectorAll('main > div > div ')).filter((section) => section.dataset.manifestId === undefined); |
Contributor
There was a problem hiding this comment.
Suggested change
| const sections = Array.from(document.querySelectorAll('main > div > div ')).filter((section) => section.dataset.manifestId === undefined); | |
| const sections = Array.from(document.querySelectorAll('main > div > div')).filter((section) => section.dataset.manifestId === undefined); |
yeibercano
reviewed
Jan 12, 2026
| function adjustTemplateDimensions(block, props, tmplt, isPlaceholder) { | ||
| const overlayCell = tmplt.querySelector(':scope > div:last-of-type'); | ||
| const divs = tmplt.querySelectorAll(':scope > div'); | ||
| const overlayCell = divs[2]; |
Contributor
There was a problem hiding this comment.
Are we always accounting there would be three divs? would it be safer to get the last one instead: const overlayCell = divs[divs.length - 1];
Contributor
|
Can you add a more reliable list of regression testing links here? |
maxn-adobe
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Briefly describe the features or fixes introduced in this PR.
Replaces fragile CSS selectors such as
:first-of-typein blocks to prevent certain edge cases caused by MEP overwriting content.Jira Ticket
Resolves: https://jira.corp.adobe.com/browse/MWPW-184504
Test URLs
Verification Steps
Potential Regressions
Additional Notes
(If applicable) Add context, related PRs, or known issues here.