This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Adding iOS XCFramework support #27
Merged
spoorthipujariadobe
merged 7 commits into
adobe:master
from
spoorthipujariadobe:unity_xcframework_support
Jan 11, 2022
Merged
Adding iOS XCFramework support #27
spoorthipujariadobe
merged 7 commits into
adobe:master
from
spoorthipujariadobe:unity_xcframework_support
Jan 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoorthipujariadobe
requested review from
emdobrin,
shtomar-adb,
sbenedicadb and
praveek
December 23, 2021 20:26
spoorthipujariadobe
force-pushed
the
unity_xcframework_support
branch
2 times, most recently
from
December 23, 2021 20:32
5a6c504
to
f2fb979
Compare
spoorthipujariadobe
force-pushed
the
unity_xcframework_support
branch
from
December 23, 2021 21:58
f2fb979
to
2fc220c
Compare
shtomar-adb
approved these changes
Dec 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have left 2 comments. Feel free to merge after addressing them.
emdobrin
reviewed
Jan 5, 2022
emdobrin
approved these changes
Jan 7, 2022
spoorthipujariadobe
force-pushed
the
unity_xcframework_support
branch
from
January 10, 2022 10:47
75aaded
to
1640769
Compare
emdobrin
reviewed
Jan 10, 2022
emdobrin
reviewed
Jan 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding XCFramework support for iOS by removing bundled iOS libraries. ACPCore XCFrameworks need to be downloaded and added to Xcode project. The steps are included in the installation instructions.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: