Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Adding iOS XCFramework support #27

Merged

Conversation

spoorthipujariadobe
Copy link
Contributor

Description

Adding XCFramework support for iOS by removing bundled iOS libraries. ACPCore XCFrameworks need to be downloaded and added to Xcode project. The steps are included in the installation instructions.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

@shtomar-adb shtomar-adb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have left 2 comments. Feel free to merge after addressing them.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@spoorthipujariadobe spoorthipujariadobe merged commit 3274c53 into adobe:master Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants