-
Notifications
You must be signed in to change notification settings - Fork 229
refactor(number-field): revamped number field component #5595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
Thanks @blunteshwar for pushing this forward! Before we dive deeper, let’s take a structured approach to these refactor PRs: What’s the scope of change? Any API changes?
Internal changes? Let’s document intent + expected outcome in the PR description as we move forward. Please add if you feel that we should cover here. This can be a generic approach for all the refactor work going forward. |
Scope of Change My primary goals with this migration are:
Long-term Benefits I’m Targeting:
My Recommended Approach
|
Description
Motivation and context
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch
,minor
, ormajor
featuresManual review test cases
Descriptive Test Statement
Descriptive Test Statement
Device review