fix(link): added delegateFocus for Safari tab index issue in shadow root #5580
+54
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c4e0daf The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsChromelink permalinktest-basic
Firefoxlink permalinktest-basic
|
added 2 commits
June 28, 2025 11:29
packages/link/src/Link.ts
Outdated
| * This enables delegatesFocus for Safari compatibility | ||
| */ | ||
| static override shadowRootOptions = { | ||
| ...LitElement.shadowRootOptions, |
There was a problem hiding this comment.
We usually use spread ...SpectrumElement.shadowRootOptions, should we also do it here?
| expect(anchor.getAttribute('tabindex')).to.eq('0'); | ||
|
|
||
| // WebKit-specific enhanced tests | ||
| if (isWebKit()) { |
There was a problem hiding this comment.
I wonder if we can remove this check and run the assertions for all browsers... any reason we need to scope it?
There was a problem hiding this comment.
Yes there is an upstream issue around this. It is a known limitation of iOS/Safari with custom elements and shadow DOM. See WebKit bug reports and related issues.
rubencarvalho
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SWC Link components
<sp-link>were not keyboard navigable on Safari/WebKit browsers, particularly when using external keyboards on iOS devices. Users could not Tab through links or use Enter/Space to activate them, making the component inaccessible in Safari.Motivation and context
Root Cause
tabindex="0", which Safari requires for keyboard navigationKey Changes
delegatesFocus: trueto shadow root configurationtabindex="0"on anchor elementBreaking Changes
None. This is a non-breaking enhancement that improves Safari compatibility while maintaining all existing APIs, styling, and behavior.
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Safari Test
Chrome Test
Firefox Test
Device review