Skip to content

chore: update web test runner and playwright #5578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TarunAdobe
Copy link
Contributor

@TarunAdobe TarunAdobe commented Jun 27, 2025

Description

This pull request updates several dependencies and configurations to ensure compatibility with the latest Playwright and @web/test-runner packages, addresses ESLint coverage for additional story files, and implements minor code improvements for clarity and standards compliance.

Changes

Dependency Updates

  • Playwright:

    • Bumped Docker image in CI from mcr.microsoft.com/playwright:v1.44.0 to v1.53.1.
    • Updated @playwright/test version from ^1.44.0 to ^1.53.1 in package.json.
  • @web/test-runner and Related Packages:

    • Updated @web/test-runner from ^0.18.3 to ^0.20.2 in both root and projects/css-custom-vars-viewer/package.json.
    • Updated @web/test-runner-junit-reporter from ^0.7.2 to ^0.8.0.
    • Updated @web/test-runner-playwright from ^0.11.0 to ^0.11.1.
    • Updated @web/test-runner-visual-regression from ^0.9.0 to ^0.10.0.
  • Linting and ESLint Configuration

    • Expanded ESLint's file matching to include **/stories/*.ts for better coverage of story files.
    • Code Improvements
  • ESM Import Syntax:

    • Changed import assertion for iconsList.json in packages/iconset/stories/icons-demo.ts from assert { type: 'json' } to the newer with { type: 'json' } syntax.
  • Visual Regression Command Import:

    • Updated the import path for visualDiff in test/visual/test.ts to reference the correct location under @web/test-runner-visual-regression/browser/commands.
  • Formatting:

    • Improved multiline arithmetic formatting in IconsDemo for readability.

Motivation and context

  • Keep dependencies up-to-date for security, performance, and compatibility.
  • Adopt the latest recommended ESM import syntax.
  • Expand linting coverage for better code quality.
  • Fix import paths in line with updated packages and best practices.

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result
  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

@TarunAdobe TarunAdobe requested a review from a team as a code owner June 27, 2025 07:38
Copy link

changeset-bot bot commented Jun 27, 2025

⚠️ No Changeset found

Latest commit: be621c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

github-actions bot commented Jun 27, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5578

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

Tachometer results

Currently, no packages are changed by this PR...

@TarunAdobe TarunAdobe changed the title Ttomar/update mwr chore: update web test runner and playwright Jun 27, 2025
@TarunAdobe TarunAdobe force-pushed the ttomar/update-mwr branch 2 times, most recently from cea0e05 to 0c584ab Compare June 28, 2025 02:27
@@ -19,7 +19,7 @@ import prettier from 'prettier';
import Case from 'case';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <import/no-extraneous-dependencies> reported by reviewdog 🐶
'case' should be listed in the project's dependencies, not devDependencies.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants