ci: deploy vrts on main branch correctly #5569

TarunAdobe · 2025-06-25T15:28:07Z

Description

Updated CircleCI configuration to ensure Visual Regression Test (VRT) results are properly deployed to Azure blob storage when running on the main branch, not just on pull requests.

Motivation and context

Previously, VRT results were only being deployed for pull requests, but main branch VRT runs were not being deployed to the preview site. This made it difficult to access and review VRT results from main branch builds, which are important for baseline comparisons and debugging.

Related issue(s)

Internal CI/CD improvement for VRT workflow

Screenshots (if appropriate)

N/A

Author's checklist

I have read the CONTRIBUTING and PULL_REQUESTS documents.
I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
I have added automated tests to cover my changes.
I have included a well-written changeset if my change needs to be published.
I have included updated documentation if my change required it.

Reviewer's checklist

Includes a Github Issue with appropriate flag or Jira ticket number without a link
Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
Automated tests cover all use cases and follow best practices for writing
Validated on all supported browsers
All VRTs are approved before the author can update Golden Hash

Manual review test cases

VRT deployment should work on main branch
1. Pushed a test commit to this branch to send vrts to /main path if the branch name matches. check this.
2. vrts are then deployed against /main path suggesting checking for branch name worked. verify the output of this job.
3. Verify VRT results are deployed to https://swcpreviews.z13.web.core.windows.net/main/express-dark-large-rtl/review/

Device review

Did it pass in Desktop?
Did it pass in (emulated) Mobile?
Did it pass in (emulated) iPad?

changeset-bot · 2025-06-25T15:28:11Z

⚠️ No Changeset found

Latest commit: 34210b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-06-25T15:29:53Z

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5569

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

github-actions · 2025-06-25T15:32:46Z

Tachometer results

Currently, no packages are changed by this PR...

Rajdeepc · 2025-06-26T06:35:54Z

@TarunAdobe How can i verify this? can you create a section on what was the issue and what is the fix for the context?

TarunAdobe · 2025-06-26T06:42:13Z

@TarunAdobe How can i verify this? can you create a section on what was the issue and what is the fix for the context?

Yusss!! will do

Rajdeepc · 2025-06-26T10:58:12Z

.circleci/config.yml

+                          # Get PR number from CircleCI environment
+                          PR_NUMBER=""
+                          if [ -n "$CIRCLE_PULL_REQUEST" ]; then
+                              PR_NUMBER=$(echo $CIRCLE_PULL_REQUEST | sed 's/.*\/pull\///')


Suggested change

PR_NUMBER=$(echo $CIRCLE_PULL_REQUEST | sed 's/.*\/pull\///')

PR_NUMBER=$(echo "$CIRCLE_PULL_REQUEST" | sed 's/.*\/pull\///')

Unquoted variables can break if they contain spaces or special characters

.circleci/config.yml

TarunAdobe · 2025-06-26T12:41:30Z

@TarunAdobe How can i verify this? can you create a section on what was the issue and what is the fix for the context?

Added a test commit to verify that checking for branch name works.
Read the testing description now and it should work

rubencarvalho · 2025-06-30T09:43:59Z

Maybe a bit outside the initial scope of this task, but I just noticed https://swcpreviews.z13.web.core.windows.net/beta/docs/ does not load correctly. Is it something we could take a look at in this PR?

.circleci/config.yml

castastrophe · 2025-07-01T16:03:38Z

.circleci/config.yml

-                          if [ -n "$PR_NUMBER" ]; then
-                              echo "Deploying VRT for PR #$PR_NUMBER (via GitHub API)"
+                      # Set deployment path based on branch
+                      if [ "$CIRCLE_BRANCH" = "ttomar/vrts-main" ]; then


Forgive my intruding if this is still in testing but is this meant to be committed?

not meant to be committed at all. would remove when somebody will approve the pr

Rajdeepc

nit: As @rubencarvalho suggested if you want to have the beta/docs rectified here its nice to have or else let's create a follow up PR and add an effort. Looks good. Thanks for doing it.

TarunAdobe · 2025-07-03T06:16:12Z

nit: As @rubencarvalho suggested if you want to have the beta/docs rectified here its nice to have or else let's create a follow up PR and add an effort. Looks good. Thanks for doing it.

already done heehhe

rubencarvalho

🚢

caseyisonit · 2025-07-08T15:03:07Z

Can you share what the skipped check is doing? or why its skipped?

TarunAdobe · 2025-07-09T06:49:10Z

Can you share what the skipped check is doing? or why its skipped?

skipped check is to clean up PR deployments from azure blob storage. it only runs once the pr is closed.

TarunAdobe requested a review from a team as a code owner June 25, 2025 15:28

Rajdeepc requested changes Jun 26, 2025

View reviewed changes

.circleci/config.yml Show resolved Hide resolved

TarunAdobe requested a review from Rajdeepc June 27, 2025 06:19

rubencarvalho reviewed Jun 30, 2025

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

TarunAdobe force-pushed the ttomar/vrts-main branch from a99e97e to 11c4916 Compare June 30, 2025 13:57

TarunAdobe requested a review from rubencarvalho July 1, 2025 07:13

castastrophe reviewed Jul 1, 2025

View reviewed changes

Rajdeepc approved these changes Jul 3, 2025

View reviewed changes

Rajdeepc added ready-for-merge Will auto-update until merged ready-for-review and removed ready-for-merge Will auto-update until merged labels Jul 7, 2025

TarunAdobe added 5 commits July 8, 2025 11:16

chore: deploy vrts on main branch correctly

cb73476

chore: test vrts

ce5febf

chore: build beta docs with updated dir

0741570

chore: fix typo in ci

893453e

chore: revert testing step in ci config

34210b0

TarunAdobe force-pushed the ttomar/vrts-main branch from 60d49f2 to 34210b0 Compare July 8, 2025 05:46

TarunAdobe requested a review from castastrophe July 8, 2025 05:46

rubencarvalho approved these changes Jul 8, 2025

View reviewed changes

	PR_NUMBER=$(echo $CIRCLE_PULL_REQUEST \| sed 's/.*\/pull\///')
	PR_NUMBER=$(echo "$CIRCLE_PULL_REQUEST" \| sed 's/.*\/pull\///')

ci: deploy vrts on main branch correctly #5569

Are you sure you want to change the base?

ci: deploy vrts on main branch correctly #5569

Conversation

TarunAdobe commented Jun 25, 2025 • edited by Rajdeepc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and context

Related issue(s)

Screenshots (if appropriate)

Author's checklist

Reviewer's checklist

Manual review test cases

Device review

Uh oh!

changeset-bot bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📚 Branch Preview

🔍 Visual Regression Test Results

Uh oh!

github-actions bot commented Jun 25, 2025

Tachometer results

Uh oh!

Rajdeepc commented Jun 26, 2025

Uh oh!

TarunAdobe commented Jun 26, 2025

Uh oh!

Rajdeepc Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TarunAdobe commented Jun 26, 2025

Uh oh!

rubencarvalho commented Jun 30, 2025

Uh oh!

Uh oh!

castastrophe Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

TarunAdobe Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

Rajdeepc left a comment

Choose a reason for hiding this comment

Uh oh!

TarunAdobe commented Jul 3, 2025

Uh oh!

rubencarvalho left a comment

Choose a reason for hiding this comment

Uh oh!

caseyisonit commented Jul 8, 2025

Uh oh!

TarunAdobe commented Jul 9, 2025

Uh oh!

Uh oh!

TarunAdobe commented Jun 25, 2025 •

edited by Rajdeepc

Loading

changeset-bot bot commented Jun 25, 2025 •

edited

Loading

github-actions bot commented Jun 25, 2025 •

edited

Loading

Rajdeepc Jun 26, 2025 •

edited

Loading