Skip to content

chore: add prelerna-publish to beta releases #5094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

rubencarvalho
Copy link
Contributor

@rubencarvalho rubencarvalho commented Feb 13, 2025

Description

We want beta release artifacts to be 1:1 with those in latest, so we need to add the prelerna-publish command which generates the custom-elements.json manifests and runs the script to verify the build artifacts.

Motivation and context

Without this, the manifests do not get published.

How has this been tested?

You can see the build artifacts of a beta test release here: https://www.npmjs.com/package/@spectrum-web-components/button/v/1.2.0-beta.3?activeTab=code

And you can see the action run here: https://github.com/adobe/spectrum-web-components/actions/runs/13309656501/job/37168759349?pr=5094

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

Copy link

changeset-bot bot commented Feb 13, 2025

⚠️ No Changeset found

Latest commit: 37867fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

Tachometer results

Currently, no packages are changed by this PR...

@rubencarvalho rubencarvalho changed the title chore: address prelerna-publish to beta releases chore: add prelerna-publish to beta releases Feb 13, 2025
@rubencarvalho rubencarvalho marked this pull request as ready for review February 13, 2025 14:21
@rubencarvalho rubencarvalho requested a review from a team as a code owner February 13, 2025 14:21
@rubencarvalho rubencarvalho merged commit ff73182 into main Feb 13, 2025
17 of 25 checks passed
@rubencarvalho rubencarvalho deleted the ruben/add-prelerna-publish-to-beta-releases branch February 13, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants