Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update checkbox and menu to latest foundations version #5069

Merged
merged 8 commits into from
Feb 11, 2025

Conversation

Rajdeepc
Copy link
Contributor

@Rajdeepc Rajdeepc commented Feb 6, 2025

Description

Bumped Checkbox and Menu components to latest S2-foundations release.

Related issue(s)

Motivation and context

Getting up to date with the latest CSS changes!

How has this been tested?

  • Test case 1

    1. Go here
    2. Do this
  • Test case 2

    1. Go here
    2. Do this
  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@Rajdeepc Rajdeepc requested a review from a team as a code owner February 6, 2025 10:32
Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: 7cea539

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

github-actions bot commented Feb 6, 2025

Tachometer results

Currently, no packages are changed by this PR...

@coveralls
Copy link
Collaborator

coveralls commented Feb 6, 2025

Pull Request Test Coverage Report for Build 13241629019

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.192%

Totals Coverage Status
Change from base Build 13199028687: 0.0%
Covered Lines: 33099
Relevant Lines: 33528

💛 - Coveralls

@Rajdeepc Rajdeepc changed the title chore: updated checkbox to latest foundations chore: updated checkbox, picker to latest foundations Feb 6, 2025
@Rajdeepc Rajdeepc changed the title chore: updated checkbox, picker to latest foundations chore: updated checkbox, picker, Menu to latest foundations Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

github-actions bot commented Feb 6, 2025

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.98 0.98
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 250.087 kB 236.838 kB 235.464 kB 🏆
Scripts 60.967 kB 54.66 kB 🏆 54.704 kB
Stylesheet 53.013 kB 47.676 kB 46.324 kB 🏆
Document 6.239 kB 5.502 kB 5.455 kB 🏆
Font 126.978 kB 126.649 kB 126.632 kB 🏆

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@rubencarvalho rubencarvalho changed the title chore: updated checkbox, picker, Menu to latest foundations chore: update checkbox and menu to latest foundations version Feb 11, 2025
Copy link
Collaborator

@rubencarvalho rubencarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the title (removed the Picker). We can follow up with that component in a focused PR! This one LGTM! 🚢

@Rajdeepc Rajdeepc merged commit 0cd4a3b into main Feb 11, 2025
21 of 25 checks passed
@Rajdeepc Rajdeepc deleted the rajdeep/update-checkbox-foundation branch February 11, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants