Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update actionbutton, ui-icons, button, popover, actiongroup and menu to latest foundations #5068

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

TarunAdobe
Copy link
Contributor

@TarunAdobe TarunAdobe commented Feb 6, 2025

Description

Updated CSS styles of actionbutton, ui-icons, icons and button, menu and popover component to align with the latest S2 foundations version.

Motivation and context

We are on a path to update our CSS dependencies to the latest tag, but until then we need to get up to speed with the latest s2-foundations.

Ticket: SWC-591

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@TarunAdobe TarunAdobe requested a review from a team as a code owner February 6, 2025 10:24
Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: b28a609

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

github-actions bot commented Feb 6, 2025

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

github-actions bot commented Feb 6, 2025

Tachometer results

Currently, no packages are changed by this PR...

Copy link

github-actions bot commented Feb 6, 2025

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 250.122 kB 236.218 kB 233.462 kB 🏆
Scripts 60.64 kB 54.24 kB 54.045 kB 🏆
Stylesheet 53.292 kB 47.559 kB 44.975 kB 🏆
Document 6.237 kB 5.454 kB 🏆 5.471 kB
Font 126.963 kB 126.614 kB 🏆 126.622 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@coveralls
Copy link
Collaborator

coveralls commented Feb 6, 2025

Pull Request Test Coverage Report for Build 13195940399

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 98.185%

Totals Coverage Status
Change from base Build 13141300428: -0.007%
Covered Lines: 32955
Relevant Lines: 33384

💛 - Coveralls

@Rajdeepc Rajdeepc changed the title chore: update actionbutton, ui-icons, tokens, button to latest chore: update actionbutton, ui-icons, tokens, button to latest foundations Feb 6, 2025
@TarunAdobe TarunAdobe changed the title chore: update actionbutton, ui-icons, tokens, button to latest foundations chore: update actionbutton, ui-icons, tokens, button, popover and menu to latest foundations Feb 7, 2025
@TarunAdobe TarunAdobe changed the title chore: update actionbutton, ui-icons, tokens, button, popover and menu to latest foundations chore: update actionbutton, ui-icons, button, popover and menu to latest foundations Feb 7, 2025
@TarunAdobe TarunAdobe changed the title chore: update actionbutton, ui-icons, button, popover and menu to latest foundations chore: update actionbutton, ui-icons, button, popover, actiongroup and menu to latest foundations Feb 7, 2025
@rubencarvalho
Copy link
Collaborator

Great work - I see a couple of things:

  1. There are lots of merge conflicts
  2. https://8857ab854c98828e85ae0fca64e2fc51--spectrum-web-components.netlify.app/review/#OverlayStories/customizedClickContent.png - how did this change originate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants