Skip to content

S2 fix(swatch): Border color for Swatch on light/dark mode #4857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

Rajdeepc
Copy link
Contributor

Border color for Swatch on light/dark mode switched to use gray instead of black so it responds to theme.

Description

Related issue(s)

Motivation and context

How has this been tested?

  • Test case 1

    1. Go here
    2. Do this
  • Test case 2

    1. Go here
    2. Do this
  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@Rajdeepc Rajdeepc self-assigned this Oct 24, 2024
@Rajdeepc Rajdeepc requested a review from a team as a code owner October 24, 2024 15:29
Copy link

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

@Rajdeepc Rajdeepc requested a review from TarunAdobe October 24, 2024 16:25
@nikkimk nikkimk self-requested a review October 24, 2024 17:36
Copy link

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 228.866 kB 216.99 kB 🏆 238.095 kB
Scripts 58.136 kB 52.424 kB 🏆 55.378 kB
Stylesheet 34.706 kB 30.146 kB 🏆 48.209 kB
Document 6.221 kB 5.459 kB 🏆 5.483 kB
Font 126.813 kB 126.613 kB 🏆 126.676 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@Rajdeepc Rajdeepc changed the title fix(swatch): Border color for Swatch on light/dark mode S2 fix(swatch): Border color for Swatch on light/dark mode Oct 28, 2024
@Rajdeepc Rajdeepc merged commit f5d73f8 into feature/SWC-1.0-RC Oct 28, 2024
13 of 57 checks passed
@Rajdeepc Rajdeepc deleted the bug/swatch-border-issue branch October 28, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants