-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(date-time-picker): added precision and value interactions #4811
Closed
mizgaionutalexandru
wants to merge
57
commits into
feature/date-time-picker
from
imizga/DTP-value-precision
Closed
feat(date-time-picker): added precision and value interactions #4811
mizgaionutalexandru
wants to merge
57
commits into
feature/date-time-picker
from
imizga/DTP-value-precision
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Precision and value interactions
Previously, the DateTimePicker had a property named
timeGranularity
. This PR changes its name toprecision
and adds theday
option tohour | minute | second
.The image below explains the different interactions between the precision property and the most specific type of the date value props (min, max or value).
A few examples:
If there is a date value prop (
min
,max
orvalue
) provided, the default precision will change to accomodate said prop. For example, ifCalendarDate
is provided but the precision isn't, the default precision will beday
. If the type provided isCalendarDateTime
orZonedDateTime
, the default precision will beminute
.If the precision is provided by the consumer it shouldn't be overridden. etc.
Note
These will all be included in the final documentation of the component in some way
Other changes
Related issue(s)
Motivation and context
This change gives the consumer more flexibility on the type of objects can be used to represent dates and makes sure that all of them aligns and interacts accordingly with the precision property and its new option. Also, the effort to improve tests readability will prove beneficial in any future development/debugging sessions.
How has this been tested?
Unit tests.
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.