chore(icons,icons-ui): fetch icons from new @spectrum-css/ui-icons package #3857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castastrophe
changed the title
9 tasks
castastrophe
commented
Dec 7, 2023
castastrophe
changed the title
Westbrook
force-pushed
the
feat-update-icon-package-source
branch
from
80b6a93 to
c26ebfb
Compare
Westbrook
reviewed
Dec 19, 2023
Westbrook
approved these changes
Dec 19, 2023
Tachometer resultsChromeaccordion permalink
action-bar permalink
action-button permalink
action-group permalink
action-menu permalink
alert-dialog permalink
button-group permalink
button permalink
card permalink
checkbox permalink
dialog permalink
field-label permalink
infield-button permalink
menu permalink
meter permalink
number-field permalink
overlay permalink
picker-button permalink
picker permalink
popover permalink
progress-bar permalink
search permalink
slider permalink
split-button permalink
swatch permalink
switch permalink
table permalink
tabs permalink
tags permalink
textfield permalink
toast permalink
tooltip permalink
top-nav permalink
Firefoxaccordion permalink
action-bar permalink
action-button permalink
action-group permalink
action-menu permalink
alert-dialog permalink
button-group permalink
button permalink
card permalink
checkbox permalink
dialog permalink
field-label permalink
infield-button permalink
menu permalink
meter permalink
number-field permalink
overlay permalink
picker-button permalink
picker permalink
popover permalink
progress-bar permalink
search permalink
slider permalink
split-button permalink
swatch permalink
switch permalink
table permalink
tabs permalink
tags permalink
textfield permalink
toast permalink
tooltip permalink
top-nav permalink
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of a clean-up effort, Spectrum CSS is moving SVG processing for the UI icons library out of the @spectrum-css/icon styles package and into it's own @adobe/spectrum-css-ui-icons package.
This draft PR was tested against a linked local version and was successful. Once we release the new package on npm, we can migrate this to ready to review.
How has this been tested?
yarn linkfor the ui-icons folderTypes of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.