feat(date-time-picker): add date/time input + picker #3838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajdeepc
reviewed
Nov 30, 2023
| ></sp-calendar> | ||
| </sp-theme> | ||
| const story = html` | ||
| <h1>${title}</h1> |
There was a problem hiding this comment.
Can you please verify whether h4 font-color changes in light and dark modes too?
There was a problem hiding this comment.
Yes, it changes automatically:
| "@spectrum-web-components/popover": "^0.40.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@spectrum-web-components/story-decorator": "^0.40.0" |
There was a problem hiding this comment.
This should be in dependency array.
There was a problem hiding this comment.
But we use it only inside Storybook, the component itself does not use this package. Do you think that we should move to be inside the dependencies array?
| </slot> | ||
| </sp-picker-button> | ||
|
|
||
| <!-- TODO: Enable "receives-focus" when calendar is navigable via keyboard --> |
There was a problem hiding this comment.
can we remove the TODO comment?
There was a problem hiding this comment.
We agreed that we will keep the ´TODO`s listed on the README file
Tachometer resultsChromeaccordion permalink
action-bar permalink
action-button permalink
action-group permalink
action-menu permalink
alert-dialog permalink
asset permalink
avatar permalink
badge permalink
banner permalink
button-group permalink
button permalink
Firefoxaccordion permalink
action-bar permalink
action-button permalink
action-group permalink
action-menu permalink
alert-dialog permalink
asset permalink
avatar permalink
badge permalink
banner permalink
button-group permalink
button permalink
|
mirekszot
force-pushed
the
paulodetarsofm/date-time-picker
branch
2 times, most recently
from
73b3d40
to
72f7822
Compare
chore(tooltip): updated tooltip documentation chore(tooltip): updated documentation for self-managed tooltip chore(tooltip): extended self-managed doc
#3800) * docs(split-view): added label for resizable examples for documentation * chore(split-view): updated readme and label logic --------- Co-authored-by: Rajdeep Chandra <rajdeepc@adobe.com> Co-authored-by: Najika Halsema Yoo <44980010+najikahalsema@users.noreply.github.com>
* chore(picker): fix for overlaid picker in mobile * chore: updated golden image cache * chore(picker): fix for overlaid picker in mobile * chore: updated golden image cache * chore(picker): added property for type * chore(picker): added type as a property * chore(picker): removing overlay type as a property * chore(picker): added triiger open decorator for custom picker * chore(picker): reverting golden hash --------- Co-authored-by: Rajdeep Chandra <rajdeepc@adobe.com>
Bumps [tar-stream](https://github.com/mafintosh/tar-stream) from 3.0.0 to 3.1.6. - [Commits](mafintosh/tar-stream@v3.0.0...v3.1.6) --- updated-dependencies: - dependency-name: tar-stream dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@spectrum-css/progressbar](https://github.com/adobe/spectrum-css/tree/HEAD/components/progressbar) from 3.0.76 to 3.0.80. - [Release notes](https://github.com/adobe/spectrum-css/releases) - [Changelog](https://github.com/adobe/spectrum-css/blob/main/components/progressbar/CHANGELOG.md) - [Commits](https://github.com/adobe/spectrum-css/commits/@spectrum-css/progressbar@3.0.80/components/progressbar) --- updated-dependencies: - dependency-name: "@spectrum-css/progressbar" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* feat: add calendar * feat: use first day of the week according to the locale * feat: add "disabled" property * feat: handle "Previous" and "Next" month buttons * feat: add locale for all stories * feat: add "min" and "max" date * refactor: add new render methods * feat: format day using Intl.NumberFormat * fix: lit-plugin "no-incompatible-property-type" * The built in converter doesn't handle the property type Date | undefined * fix: packages version + property type error * refactor: add to-do list to README * feat: add event handlers and slots for icons * refactor(calendar): update dependencies * refactor(calendar): changing Lit resource import source * refactor: add comments and use correct formatters * refactor: convert property `_locale` to a getter * refactor: remove `_` from private properties and methods * refactor: remove unnecessary method * refactor: remove unnecessary template checking * refactor: add new private properties * refactor: code improvements, new comments * refactor: remove reflect from properties they don't need * fix: add new package to tsconfig.json * refactor: use same version of `@internationalized/number` used by other components * refactor(calendar): improvements and new TODOs
mirekszot
force-pushed
the
paulodetarsofm/date-time-picker
branch
from
72f7822
to
34f78a0
Compare
|
Closing this PR due rebase mismatch, will be reopened here #3856 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the third component that will be part of the date/time selector: the date/time field itself. The time field, which had been created in this PR, will no longer be used, inside the popover we will only have the calendar, at least for now.
Related issue(s)
Motivation and context
Allow the user to set the date and time to publish a post on social media.
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.