fix(overlay): allow "receives-focus" to target the root of an overlay #3658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajdeepc
reviewed
Sep 18, 2023
| interaction, | ||
| open, | ||
| placement, | ||
| receivesFocus, |
There was a problem hiding this comment.
can we write something like receivesFocus='auto' as a default value if it doesn't receive any value instead of adding a || in the .receivesFocus attr
Rajdeepc
approved these changes
Sep 18, 2023
Tachometer resultsChromeaction-bar permalink
action-menu permalink
menu permalink
overlay permalink
picker permalink
popover permalink
split-button permalink
tooltip permalink
Firefoxaction-bar permalink
action-menu permalink
menu permalink
overlay permalink
picker permalink
popover permalink
split-button permalink
tooltip permalink
|
TarunAdobe
pushed a commit
that referenced
this pull request
Sep 20, 2023
…#3658) * fix(overlay): allow "receives-focus" to target the root of an overlay * ci: update golden images cache * docs(overlay): massage types
TarunAdobe
pushed a commit
that referenced
this pull request
Sep 21, 2023
…#3658) * fix(overlay): allow "receives-focus" to target the root of an overlay * ci: update golden images cache * docs(overlay): massage types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ability for the Overlay to pass focus focus to a root element in the Overlay rather than only child content.
Related issue(s)
How has this been tested?
Types of changes
Checklist