Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Coach Mark action menu only shows up if there is also both a primaryCTA and secondaryCTA defined. #4789

Open
1 task done
mscherotter opened this issue Oct 1, 2024 · 1 comment
Labels
Component: Coach Mark enhancement New feature or request jira ticket created triage An issue needing triage

Comments

@mscherotter
Copy link

mscherotter commented Oct 1, 2024

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Add-on development for Adobe Express

Expected behavior

As described at Using Action Menu in the documentation for the Coach Mark, you can define an action menu to interact with the coaching. Because the code in Coachmark.dev.js render() function only calls the renderActionMenu when both the secondaryCTA and primaryCTA are defined.

In my use case, I have steps were no actions (in the case where I want the user to interact with my add-on's UI) and in some there is only one CTA action. Can you please take the when gate off so that the renderActionMenu gets called whenever there is an action menu defined?

I would expect to be able to have an action menu which is not dependent on also having primaryCTA and secondaryCTA defined.

Actual behavior

the action menu only shows up when both the primaryCTA and secondaryCTA are defined.

Screenshots

In this case, I only have one CTA button and want to show my action menu to skip or restart the tour :
image

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to '...'
  2. Click on '....'
  3. Scroll to '....'
  4. Check console
  5. See error

Sample code or abstract reproduction which illustrates the problem

No response

Severity

SEV 4

Logs taken while reproducing problem

No response

@mscherotter mscherotter added bug Something isn't working needs jira ticket triage An issue needing triage labels Oct 1, 2024
@najikahalsema najikahalsema added enhancement New feature or request Component: Coach Mark jira ticket created and removed bug Something isn't working needs jira ticket labels Oct 8, 2024
@najikahalsema
Copy link
Collaborator

@mscherotter Hi, I have a few questions for you.

The documentation you linked says:

The should only include ways to interact with the coach mark tour as a whole, with options like “Skip tour” or “Restart tour.”

Your request is:

I have steps were no actions (in the case where I want the user to interact with my add-on's UI) and in some there is only one CTA action.

So, if I understand correctly, an example of your use case would be something like:

  1. The user is in the middle of a coachmark tutorial.
  2. The tutorial tells the user to interact with part of the application UI, eg "Try using the select tool", which would be an action button below the overlaid coachmark content.
  3. The expectation is that the user navigates to this other button in order to progress the tutorial.

My questions:

  • How is the coachmark related in the DOM to the action you want the user to take?
  • How would the user progress through the tutorial once they've completed the action? Is your expectation that the tour would progress to the next step automatically, or would a "next" button reappear once the desired action has been completed by the user? If it's automatic, what interaction would trigger the tutorial to progress?

Without allowing the user to control how they interact with the tutorial, you're locking them into an experience, essentially. I have concerns about this UX. Please let me know if I'm understanding your use case correctly so that we can proceed. Thank you!

cc @rubencarvalho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Coach Mark enhancement New feature or request jira ticket created triage An issue needing triage
Projects
None yet
Development

No branches or pull requests

2 participants