fix: prevent runaway event listeners by not rendering while disconnected

adobe · Aug 26, 2022 · aa8e8b2 · aa8e8b2
1 parent 2932392
commit aa8e8b2
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/packages/table/src/Table.ts b/packages/table/src/Table.ts
@@ -443,6 +443,9 @@ export class Table extends SizedMixin(SpectrumElement, {
     }
 
     protected renderVirtualizedItems(index?: number): void {
+        // Rendering updates into the table while disconnected can
+        // cause runaway event binding in ancestor elements.
+        if (!this.isConnected) return;
         if (!this.tableBody) {
             this.tableBody = this.querySelector('sp-table-body') as TableBody;
             if (!this.tableBody) {
@@ -478,4 +481,11 @@ export class Table extends SizedMixin(SpectrumElement, {
             this.tableBody
         );
     }
+
+    public override disconnectedCallback(): void {
+        if (this.tableBody) {
+            render(html``, this.tableBody);
+        }
+        super.disconnectedCallback();
+    }
 }