fix(textfield): remove use of sp-icons-*

adobe · Apr 15, 2020 · 9a5c213 · 9a5c213
1 parent 95b96b8
commit 9a5c213
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 17 deletions.
diff --git a/packages/checkbox/test/checkbox.test.ts b/packages/checkbox/test/checkbox.test.ts
@@ -42,8 +42,6 @@ describe('Checkbox', () => {
         testFixture = await fixture<HTMLDivElement>(
             html`
                 <div>
-                    <sp-icons-medium></sp-icons-medium>
-
                     <div id="test-checkbox">
                         <sp-checkbox id="checkbox0" tabindex="5">
                             Component

diff --git a/packages/textfield/package.json b/packages/textfield/package.json
@@ -46,7 +46,7 @@
     },
     "dependencies": {
         "@spectrum-web-components/icon": "^0.4.5",
-        "@spectrum-web-components/icons": "^0.3.0",
+        "@spectrum-web-components/icons-ui": "^0.0.1",
         "@spectrum-web-components/shared": "^0.4.5",
         "tslib": "^1.10.0"
     }

diff --git a/packages/textfield/src/textfield.ts b/packages/textfield/src/textfield.ts
@@ -21,7 +21,10 @@ import {
 
 import { Focusable } from '@spectrum-web-components/shared/lib/focusable.js';
 import '@spectrum-web-components/icon';
-import '@spectrum-web-components/icons';
+import {
+    AlertSmallIcon,
+    CheckmarkSmallIcon,
+} from '@spectrum-web-components/icons-ui';
 
 import textfieldStyles from './textfield.css.js';
 import checkmarkSmallStyles from '@spectrum-web-components/icon/lib/spectrum-icon-checkmark-small.css.js';
@@ -114,21 +117,15 @@ export class Textfield extends Focusable {
     protected renderStateIcons(): TemplateResult | typeof nothing {
         if (this.invalid) {
             return html`
-                <sp-icons-large></sp-icons-large>
-                <sp-icon
-                    id="invalid"
-                    name="ui:AlertSmall"
-                    class="alert-small"
-                ></sp-icon>
+                <sp-icon id="invalid" class="alert-small">
+                    ${AlertSmallIcon({ hidden: true })}
+                </sp-icon>
             `;
         } else if (this.valid) {
             return html`
-                <sp-icons-large></sp-icons-large>
-                <sp-icon
-                    id="valid"
-                    name="ui:CheckmarkSmall"
-                    class="checkmark-small"
-                ></sp-icon>
+                <sp-icon id="valid" class="checkmark-small">
+                    ${CheckmarkSmallIcon({ hidden: true })}
+                </sp-icon>
             `;
         }
         return nothing;

diff --git a/packages/textfield/tsconfig.json b/packages/textfield/tsconfig.json
@@ -8,7 +8,7 @@
     "include": ["src/*.ts"],
     "references": [
         { "path": "../icon" },
-        { "path": "../icons" },
+        { "path": "../icons-ui" },
         { "path": "../shared" }
     ]
 }