fix(number-field): handles values greater than 1000 (#4417)

* fix(number-field): handles values greater than 1000 * chore(number-field): updated tests --------- Co-authored-by: Rajdeep Chandra <rajdeepchandra@Rajdeeps-MacBook-Pro-2.local>
adobe · May 8, 2024 · 45d69d0 · 45d69d0
1 parent 3a57f89
commit 45d69d0
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/packages/number-field/src/NumberField.ts b/packages/number-field/src/NumberField.ts
@@ -575,7 +575,10 @@ export class NumberField extends TextfieldBase {
                 : 0;
             this._valueFormatter = new NumberFormatter(
                 this.languageResolver.language,
-                { maximumFractionDigits: digitsAfterDecimal }
+                {
+                    maximumFractionDigits: digitsAfterDecimal,
+                    useGrouping: false,
+                }
             );
         }
 

diff --git a/packages/number-field/test/number-field.test.ts b/packages/number-field/test/number-field.test.ts
@@ -146,6 +146,31 @@ describe('NumberField', () => {
             expect(el.valueAsString).to.equal('-2.4');
             expect(el.focusElement.value).to.equal('-2.4');
         });
+        it('correctly handles max values greater than 1000 with step=1', async () => {
+            const el = await getElFrom(
+                Default({
+                    step: 1,
+                    min: 0,
+                    max: 200000,
+                    value: 999,
+                })
+            );
+
+            await clickBySelector(el, '.step-up');
+
+            expect(el.value).to.equal(1000);
+            expect(el.valueAsString).to.equal('1000');
+            expect(el.formattedValue).to.equal('1,000');
+            expect(el.focusElement.value).to.equal('1,000');
+
+            el.value = 15000;
+            await elementUpdated(el);
+
+            expect(el.value).to.equal(15000);
+            expect(el.valueAsString).to.equal('15000');
+            expect(el.formattedValue).to.equal('15,000');
+            expect(el.focusElement.value).to.equal('15,000');
+        });
     });
     describe('Increments', () => {
         let el: NumberField;
@@ -164,6 +189,7 @@ describe('NumberField', () => {
             expect(el.value).to.be.NaN;
             expect(el.focusElement.value).to.equal('');
         });
+
         it('via pointer', async () => {
             await clickBySelector(el, '.step-up');
             expect(el.formattedValue).to.equal('0');