fix(schemas): make gallery variant inherit baseCard properties#619
Open
fix(schemas): make gallery variant inherit baseCard properties#619
Conversation
- Update gallery variant to use allOf pattern with baseCard reference - Ensures gallery variant supports all state properties (state, isSelected, isQuiet, etc.) - Maintains consistency across all card variants - Add comprehensive test suite to validate inheritance structure - All 36 tests passing including 9 new inheritance tests
🦋 Changeset detectedLatest commit: c66854e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
Run report for c66854e0Total time: 29.4s | Comparison time: 33.9s | Estimated savings: 4.5s (13.3% faster)
Touched files |
Contributor
🧩 Component Schema Changes ReportComponent Schemas Changed (1 added, 1 deleted, 1 updated)Original Branch: New Branch: 🚨 Breaking Changes DetectedThis PR introduces 2 breaking change(s) to component schemas. Please review carefully and ensure proper versioning. 📦 Added Components (1)
❌ Deleted Components (1)
|
…otes - Add analyzeOneOfChanges function to handle schema structure changes - Add identifyVariantType function to identify variant types - Update enhanceChangeDescriptions to process oneOf changes - Update markdown template to display oneOf changes - Provides meaningful change descriptions for release notes Fixes issue where oneOf schema changes were detected but not described in GitHub Actions comments, making it difficult to understand what changed.
- Add function-based filtering to exclude .changeset/*.md files from remark processing - Preserve YAML frontmatter in changeset files during lint-staged - Keep changeset linter validation for proper changeset format checking - Add changeset file for cards gallery variant inheritance fix
GarthDB
force-pushed
the
garthdb/fix-cards-options
branch
from
33e2e97 to
64ef08c
Compare
- Add resolveRefs function to resolve $ref references in allOf arrays - Update getSchemaBySlug and getAllSchemas to return resolved schemas - Merge baseCard properties directly into card variant properties - Add comprehensive test suite for ref resolution functionality - Update existing cards inheritance tests to work with resolved structure - All 42 tests passing including 6 new ref resolution tests This makes schemas more developer-friendly by showing inherited properties directly instead of requiring $ref traversal.
cursor bot
pushed a commit
that referenced
this pull request
Feb 5, 2026
Reviewed all 8 open pull requests and identified 4 that should be closed: - PR #352 (20 months old, merge conflicts) - PR #481 (11 months old, merge conflicts, CI failing) - PR #619 (4 months old, merge conflicts, CI failing) - PR #620 (4 months old, merge conflicts, CI failing) Created comprehensive documentation with: - Analysis of each PR's status - Recommended closing comments - Commands to execute closures - Statistics and rationale Co-authored-by: Garth Braithwaite <garthdb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed inconsistency in cards schema where gallery variant was missing baseCard reference, preventing it from inheriting state properties like other card variants.
Related Issue
N/A - Schema consistency improvement
Motivation and Context
The gallery variant was structured differently from other card variants, missing the baseCard reference that provides common state properties (state, isSelected, isQuiet, isDisabled, etc.). This made the schema inconsistent and unpredictable for developers.
How Has This Been Tested?
Types of changes
Checklist: