Skip to content

Spectrum tokens 17 - Tooltip #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Conversation

jianliao
Copy link
Contributor

@jianliao jianliao commented Sep 21, 2020

Description

Avoid the tooltip label overlaps on the icon and still preserved the max-width.

Fixed #847

How and where has this been tested?

  • How this was tested:
  • Browser(s) and OS(s) this was tested with:

Screenshots

Before:
image
After:
image

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@adobe-spectrum-bot
Copy link
Collaborator

Spectrum CSS documentation build successfully! 🎉

View the documentation

@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@jianliao jianliao changed the title fix: tooltip with an icon on the left Spectrum tokens update 17 - Tooltip Sep 21, 2020
@jianliao jianliao changed the title Spectrum tokens update 17 - Tooltip Spectrum tokens 17 - Tooltip Sep 21, 2020
@GarthDB GarthDB merged commit d696b2c into spectrum-tokens-17 Sep 21, 2020
@GarthDB GarthDB deleted the spectrum-tokens-17-tooltip branch September 21, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants