Skip to content

Spectrum tokens 17 switch #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2020
Merged

Spectrum tokens 17 switch #925

merged 2 commits into from
Sep 21, 2020

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Sep 17, 2020

Description

Added migration guides

closes #137
closes #460
closes #855

Screenshots

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@GarthDB GarthDB requested a review from lazd September 17, 2020 21:59
@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

lazd
lazd requested changes Sep 21, 2020
View reviewed changes
Copy link
Member

@lazd lazd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give some guidance on what to do instead of A/B

@GarthDB GarthDB merged commit 645d637 into spectrum-tokens-17 Sep 21, 2020
@GarthDB GarthDB deleted the spectrum-tokens-17-switch branch September 21, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazd lazd lazd requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GarthDB @adobe-spectrum-bot @lazd