Skip to content

Spectrum tokens 17 tabs #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Conversation

jianliao
Copy link
Contributor

@jianliao jianliao commented Sep 16, 2020

Description

Change workflow icon size to medium.

How and where has this been tested?

  • How this was tested:
  • Browser(s) and OS(s) this was tested with:

Screenshots

After apply the change, only two scenarios failed. They're caused by line-height change.
image
image

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@jianliao jianliao changed the base branch from main to spectrum-tokens-17 September 16, 2020 20:41
@jianliao
Copy link
Contributor Author

As there is no VRT result from Travis-CI, here is the VRT generated by Adobe internal jenkins for this branch. https://spectrum-visual-regression.ci.corp.adobe.com/view/Spectrum%20CSS/job/spectrum-css-vr-essential-test/15/artifact/light_medium/backstop_data/html_report/index.html

@GarthDB GarthDB merged commit 347b74e into spectrum-tokens-17 Sep 17, 2020
@GarthDB GarthDB deleted the spectrum-tokens-17-tabs branch September 17, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants