Skip to content

Spectrum tokens 17 - Pagination #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2020

Conversation

jianliao
Copy link
Contributor

@jianliao jianliao commented Sep 10, 2020

Description

Fixed #859
Change pagination counter text color to match with DL.

This issue is blocked by the solution of #913

How and where has this been tested?

  • How this was tested:
  • Browser(s) and OS(s) this was tested with:

Screenshots

DL:
image

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@lazd
Copy link
Member

lazd commented Sep 15, 2020

Hmm, looks like this is something that should be addressed with a solution to #913... However, this solution isn't the worst in the meantime, but I think I'd rather see it solved properly and left the wrong color in the meantime.

@jianliao jianliao added the blocked See description and comments for what is blocking this issue label Sep 15, 2020
@jianliao jianliao changed the title fix: change pagination counter text color to match design Spectrum tokens 17 - Pagination Sep 21, 2020
@GarthDB GarthDB merged commit 4157b27 into spectrum-tokens-17 Sep 21, 2020
@GarthDB GarthDB deleted the spectrum-tokens17-paginations branch September 21, 2020 22:29
@GarthDB GarthDB restored the spectrum-tokens17-paginations branch September 21, 2020 22:29
GarthDB added a commit that referenced this pull request Sep 21, 2020
@GarthDB
Copy link
Member

GarthDB commented Sep 21, 2020

I'm closing this because it actually appears fixed in a future release of DNA for some of the components and we can do it at the same time. I'll open an issue specifically for pagination.

@GarthDB GarthDB deleted the spectrum-tokens17-paginations branch September 21, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked See description and comments for what is blocking this issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants