Skip to content

Spectrum tokens 17 accordion #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2020
Merged

Spectrum tokens 17 accordion #886

merged 3 commits into from
Sep 8, 2020

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Sep 2, 2020

Description

accordion is a contribution with a UI kit, so I removed most of the hardcoded values in favor of DNA accordion tokens and calculated tokens based on DNA accordion tokens.

Closes #806

How and where has this been tested?

  • MacOS Version 85.0.4183.83 (Official Build) (64-bit)

Screenshots

Old:
image
New:
image

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@GarthDB GarthDB added this to the Token Deprecation milestone Sep 2, 2020
@GarthDB GarthDB changed the title fix: removed global and deprecated tokens, closes #806 Spectrum tokens 17 accordion Sep 2, 2020
@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

Copy link
Contributor

@jianliao jianliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@GarthDB GarthDB merged commit 9e8f3c7 into spectrum-tokens-17 Sep 8, 2020
@GarthDB GarthDB deleted the issue/806 branch September 23, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants