fix: allow high contrast mode for checkboxes #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partly resolves adobe#786
|
Thanks for this! We will put some time into reviewing it and get back to you soon. |
lazd
pushed a commit
that referenced
this pull request
Sep 22, 2020
partly resolves #786 This will not work in IE11 or with our legacy build. It must support CSS vars.
GarthDB
added a commit
that referenced
this pull request
Sep 22, 2020
* feat: tags contributd by rsp@v3 * fix: move border-radius setting to index.css * fix: add back the margin-inline-end for the tag has icon or avatar * fix: fix truncation example for tag and fix clear button size * fix: remove the margin-left for clearButton * fix: adjust the color to match design for standard tag item * fix: implements the background for clearButton * fix: fix some mismatch between impl and design xd * fix: mix tag with or without icon/avatar * fix: use dna variables for border-shadow and border-size * fix: update dna variable for focus-ring and border-size * Performance for focus-ring transition box-shadow is hard, opacity is easy * build(deps-dev): bump prismjs from 1.17.1 to 1.21.0 Bumps [prismjs](https://github.com/PrismJS/prism) from 1.17.1 to 1.21.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.17.1...v1.21.0) Signed-off-by: dependabot[bot] <support@github.com> * fix: fix the issues caused by component rename (#778) * fix: fix the issues caused by component rename * fix: fix package security vulnerabilities Co-authored-by: Jian Liao <jianliao@adobe.com> * test: update VRT instruction documentation (#772) * test: update VRT instruction documentation * docs: fixed typo Co-authored-by: Jian Liao <jianliao@adobe.com> Co-authored-by: Garth Braithwaite <garthdb@gmail.com> * fix: high contrast mode for checkboxes. (#791) partly resolves #786 This will not work in IE11 or with our legacy build. It must support CSS vars. Co-authored-by: Milan Brkic <milan.brkic1@yahoo.com> Co-authored-by: Jian Liao <jianliao@adobe.com> Co-authored-by: Rob Snow <rsnow@adobe.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jian Liao <jianliao@users.noreply.github.com> Co-authored-by: Aaron <misterbrownlee@users.noreply.github.com> Co-authored-by: James Nurthen <jnurthen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for checkbox part of #786.
This changes checkboxes to work in the following ways in WHCM
Note - I am unsure how to mark error state and am in discussions with Spectrum. IMO this can be tackled in a later PR.
How and where has this been tested?
Screenshots
To-do list