Skip to content

fix: make SearchWithin use new Textfield markup #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2020
Merged

fix: make SearchWithin use new Textfield markup #645

merged 3 commits into from
Apr 2, 2020

Conversation

lazd
Copy link
Member

@lazd lazd commented Mar 16, 2020 •
edited
Loading

Description

How and where has this been tested?

  • How this was tested:
  • Browser(s) and OS(s) this was tested with:

Screenshots

image

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/002c287-result-2020-03-16_17-58-31/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/002c287-result-2020-03-16_17-58-31/dist/docs/

@lazd lazd marked this pull request as ready for review March 16, 2020 18:22
@jianliao
Copy link
Contributor

jianliao commented Mar 16, 2020 •
edited
Loading

There is a new class named - spectrum-SearchWithin-dropdown introduced, it may need a migration guide?

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/4a21fd8-result-2020-03-16_18-29-54/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/4a21fd8-result-2020-03-16_18-29-54/dist/docs/

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/07c1f1f-result-2020-03-16_18-30-30/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/07c1f1f-result-2020-03-16_18-30-30/dist/docs/

@lazd
Copy link
Member Author

lazd commented Mar 16, 2020

@jianliao ah! Of course. I'll write the migration guide.

@jianliao jianliao added Component: Search documentation Because documentation is important and shouldn't be broken labels Mar 23, 2020
@GarthDB GarthDB merged commit 262d5d7 into master Apr 2, 2020
@GarthDB GarthDB deleted the searchwithin branch April 2, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianliao jianliao jianliao approved these changes

Assignees
No one assigned
Labels
documentation Because documentation is important and shouldn't be broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lazd @adobe-spectrum-bot @jianliao @GarthDB